Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
ef99b5e8
Commit
ef99b5e8
authored
Feb 07, 2017
by
Kushal Pandya
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use plain JS within `clickTab`, make comment more concise
parent
f9c23de6
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
4 deletions
+10
-4
app/assets/javascripts/merge_request_tabs.js.es6
app/assets/javascripts/merge_request_tabs.js.es6
+10
-4
No files found.
app/assets/javascripts/merge_request_tabs.js.es6
View file @
ef99b5e8
...
@@ -102,12 +102,18 @@ require('./flash');
...
@@ -102,12 +102,18 @@ require('./flash');
}
}
clickTab(e) {
clickTab(e) {
const targetLink = $(e.target).attr('href');
if (e.target) {
const targetLink = e.target.getAttribute('href');
// Allow following special clicks to make link open in new tab
// 1) Cmd + Click on Mac (e.metaKey)
// 2) Ctrl + Click on PC (e.ctrlKey)
// 3) Middle-click or Mouse Wheel Click (e.which is 2)
if (e.metaKey || e.ctrlKey || e.which === 2) {
if (e.metaKey || e.ctrlKey || e.which === 2) {
e.stopImmediatePropagation();
e.stopImmediatePropagation();
window.open(targetLink, '_blank');
window.open(targetLink, '_blank');
}
}
}
}
}
tabShown(e) {
tabShown(e) {
const $target = $(e.target);
const $target = $(e.target);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment