Apply commit: Disallow any compensation.

From Lukasz Nowak:

1- Compensation is undesired. (51c8a250)

  Raise loudly with message.

2- Disallow any compensation. (3c74ed07)

3- Emit more informative log. (534b2e77)

product/ERP5/mixin/rule.py

@@ -38,6 +38,7 @@ from Products.ERP5Type.Errors import SimulationError
 from Products.ERP5Type.TransactionalVariable import getTransactionalVariable
 from Products.ERP5.ExpandPolicy import policy_dict
 from Products.ERP5.MovementCollectionDiff import _getPropertyAndCategoryList
+from pprint import pformat
 
 from zLOG import LOG
 
@@ -367,6 +368,9 @@ class RuleMixin(Predicate):
         if quantity:
           if decision_movement.isFrozen():
             # Compensate
+            raise NotImplementedError(
+              'Compensation undesired: decision_movement %s = %s' % (decision_movement.getPath(),
+              pformat(decision_movement.__dict__), ))
             new_movement = decision_movement.asContext(quantity=-quantity)
             new_movement.setDelivery(None)
             movement_collection_diff.addNewMovement(new_movement)
@@ -414,6 +418,12 @@ class RuleMixin(Predicate):
             not_completed_movement = decision_movement
           # Frozen must be compensated
           if not _compare(profit_tester_list, prevision_movement, decision_movement):
+            raise NotImplementedError(
+              'Compensation undesired: prevision_movement %s = %s decision_movement %s = %s' % (
+                prevision_movement.getPath(),
+                pformat(prevision_movement.__dict__),
+                decision_movement.getPath(),
+                pformat(decision_movement.__dict__) ))
             new_movement = decision_movement.asContext(
                                 quantity=-decision_movement_quantity)
             new_movement.setDelivery(None)
@@ -432,6 +442,12 @@ class RuleMixin(Predicate):
         if decision_movement.isFrozen():
           # Frozen must be compensated
           if not _compare(divergence_tester_list, prevision_movement, decision_movement):
+            raise NotImplementedError(
+              'Compensation undesired: prevision_movement %s = %s decision_movement %s = %s' % (
+                prevision_movement.getPath(),
+                pformat(prevision_movement.__dict__),
+                decision_movement.getPath(),
+                pformat(decision_movement.__dict__) ))
             new_movement = decision_movement.asContext(
                                   quantity=-decision_movement_quantity)
             new_movement.setDelivery(None)