Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
slapos
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Aurel
slapos
Commits
9532a30b
Commit
9532a30b
authored
Jul 05, 2013
by
Benjamin Blanc
Browse files
Options
Browse Files
Download
Plain Diff
Merge master
parents
934b624b
e05c9b05
Changes
10
Show whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
143 additions
and
36 deletions
+143
-36
component/cloudooo/buildout.cfg
component/cloudooo/buildout.cfg
+1
-1
component/python-2.7/buildout.cfg
component/python-2.7/buildout.cfg
+3
-0
slapos/recipe/generic_mysql/mysql.py
slapos/recipe/generic_mysql/mysql.py
+2
-0
slapos/recipe/haproxy/__init__.py
slapos/recipe/haproxy/__init__.py
+5
-0
software/cloudooo/software.cfg
software/cloudooo/software.cfg
+0
-15
software/erp5-util-testing/instance.cfg
software/erp5-util-testing/instance.cfg
+2
-0
stack/cloudooo.cfg
stack/cloudooo.cfg
+0
-5
stack/erp5/buildout.cfg
stack/erp5/buildout.cfg
+105
-5
stack/erp5/instance-scalability.cfg.in
stack/erp5/instance-scalability.cfg.in
+13
-10
stack/erp5/instance.cfg.in
stack/erp5/instance.cfg.in
+12
-0
No files found.
component/cloudooo/buildout.cfg
View file @
9532a30b
...
@@ -22,7 +22,7 @@ git-executable = ${git:location}/bin/git
...
@@ -22,7 +22,7 @@ git-executable = ${git:location}/bin/git
[cloudooo]
[cloudooo]
recipe = zc.recipe.egg
recipe = zc.recipe.egg
python = python2.
6
python = python2.
7
extra-paths = ${cloudooo-repository:location}
extra-paths = ${cloudooo-repository:location}
eggs =
eggs =
${lxml-python:egg}
${lxml-python:egg}
...
...
component/python-2.7/buildout.cfg
View file @
9532a30b
...
@@ -44,6 +44,9 @@ configure-options =
...
@@ -44,6 +44,9 @@ configure-options =
--enable-unicode=ucs4
--enable-unicode=ucs4
--with-system-expat
--with-system-expat
--with-threads
--with-threads
# Profiled build:
make-binary =
make-targets = make profile-opt && make install
# the entry "-Wl,-rpath=${file:location}/lib" below is needed by python-magic,
# the entry "-Wl,-rpath=${file:location}/lib" below is needed by python-magic,
# which would otherwise load the system libmagic.so with ctypes
# which would otherwise load the system libmagic.so with ctypes
...
...
slapos/recipe/generic_mysql/mysql.py
View file @
9532a30b
...
@@ -68,6 +68,7 @@ def updateMysql(args):
...
@@ -68,6 +68,7 @@ def updateMysql(args):
while
True
:
while
True
:
mysql_upgrade_list
=
[
conf
[
'mysql_upgrade_binary'
],
'--user=root'
]
mysql_upgrade_list
=
[
conf
[
'mysql_upgrade_binary'
],
'--user=root'
]
if
'socket'
in
conf
:
if
'socket'
in
conf
:
mysql_upgrade_list
.
insert
(
1
)
mysql_upgrade_list
.
append
(
'--socket='
+
conf
[
'socket'
])
mysql_upgrade_list
.
append
(
'--socket='
+
conf
[
'socket'
])
mysql_upgrade
=
subprocess
.
Popen
(
mysql_upgrade_list
,
stdout
=
subprocess
.
PIPE
,
stderr
=
subprocess
.
STDOUT
)
mysql_upgrade
=
subprocess
.
Popen
(
mysql_upgrade_list
,
stdout
=
subprocess
.
PIPE
,
stderr
=
subprocess
.
STDOUT
)
result
=
mysql_upgrade
.
communicate
()[
0
]
result
=
mysql_upgrade
.
communicate
()[
0
]
...
@@ -82,6 +83,7 @@ def updateMysql(args):
...
@@ -82,6 +83,7 @@ def updateMysql(args):
print
"No need to upgrade MySQL database"
print
"No need to upgrade MySQL database"
mysql_list
=
[
conf
[
'mysql_binary'
].
strip
(),
'-B'
,
'--user=root'
]
mysql_list
=
[
conf
[
'mysql_binary'
].
strip
(),
'-B'
,
'--user=root'
]
if
'socket'
in
conf
:
if
'socket'
in
conf
:
mysql_list
.
insert
(
1
)
mysql_list
.
append
(
'--socket='
+
conf
[
'socket'
])
mysql_list
.
append
(
'--socket='
+
conf
[
'socket'
])
mysql
=
subprocess
.
Popen
(
mysql_list
,
stdin
=
subprocess
.
PIPE
,
mysql
=
subprocess
.
Popen
(
mysql_list
,
stdin
=
subprocess
.
PIPE
,
stdout
=
subprocess
.
PIPE
,
stderr
=
subprocess
.
STDOUT
)
stdout
=
subprocess
.
PIPE
,
stderr
=
subprocess
.
STDOUT
)
...
...
slapos/recipe/haproxy/__init__.py
View file @
9532a30b
...
@@ -25,6 +25,7 @@
...
@@ -25,6 +25,7 @@
#
#
##############################################################################
##############################################################################
from
slapos.recipe.librecipe
import
GenericBaseRecipe
from
slapos.recipe.librecipe
import
GenericBaseRecipe
from
zc.buildout
import
UserError
class
Recipe
(
GenericBaseRecipe
):
class
Recipe
(
GenericBaseRecipe
):
"""
"""
...
@@ -80,6 +81,10 @@ class Recipe(GenericBaseRecipe):
...
@@ -80,6 +81,10 @@ class Recipe(GenericBaseRecipe):
backend_dict
=
{
backend_dict
=
{
self
.
options
[
'name'
]:
(
self
.
options
[
'port'
],
backend_list
),
self
.
options
[
'name'
]:
(
self
.
options
[
'port'
],
backend_list
),
}
}
if
not
backend_dict
:
# Fail installation if backend_dict is empty, otherwise partition may be
# advertised as available although it provides no service.
raise
UserError
(
'backend-dict is empty'
)
server_snippet_filename
=
self
.
getTemplateFilename
(
server_snippet_filename
=
self
.
getTemplateFilename
(
'haproxy-server-snippet.cfg.in'
)
'haproxy-server-snippet.cfg.in'
)
...
...
software/cloudooo/software.cfg
View file @
9532a30b
...
@@ -14,8 +14,6 @@ parts +=
...
@@ -14,8 +14,6 @@ parts +=
# Local development
# Local development
slapos.cookbook-repository
slapos.cookbook-repository
check-recipe
check-recipe
slapos.cookbook-python2.6
slapos.recipe.template-python2.6
# Create instance template
# Create instance template
template
template
...
@@ -38,19 +36,6 @@ stop-on-error = true
...
@@ -38,19 +36,6 @@ stop-on-error = true
update-command = ${:command}
update-command = ${:command}
command = grep parts ${buildout:develop-eggs-directory}/slapos.cookbook.egg-link
command = grep parts ${buildout:develop-eggs-directory}/slapos.cookbook.egg-link
[slapos.cookbook-python2.6]
recipe = zc.recipe.egg
eggs = slapos.cookbook
scripts =
python = python2.6
ugly-depend-on = ${slapos.cookbook-repository:command} ${slapos.cookbook-repository:update-command}
[slapos.recipe.template-python2.6]
recipe = zc.recipe.egg
eggs = slapos.recipe.template
scripts =
python = python2.6
[template-jinja2-base]
[template-jinja2-base]
recipe = slapos.recipe.template:jinja2
recipe = slapos.recipe.template:jinja2
template = ${:_profile_base_location_}/${:filename}.in
template = ${:_profile_base_location_}/${:filename}.in
...
...
software/erp5-util-testing/instance.cfg
View file @
9532a30b
...
@@ -28,6 +28,8 @@ repository = ${erp5-util-repository:location}
...
@@ -28,6 +28,8 @@ repository = ${erp5-util-repository:location}
recipe = slapos.cookbook:egg_test
recipe = slapos.cookbook:egg_test
run-test-suite = $${create-directory:bin}/runTestSuite
run-test-suite = $${create-directory:bin}/runTestSuite
run-test-suite-binary = ${buildout:bin-directory}/runTestSuite
run-test-suite-binary = ${buildout:bin-directory}/runTestSuite
run-scalability-test-suite = $${create-directory:bin}/runScalabilityTestSuite
run-scalability-test-suite-binary = $${buildout:bin-directory}/runScalabilityTestSuite
# The list of executables should be defined here and a combination
# The list of executables should be defined here and a combination
# of tests should dynamically generated.
# of tests should dynamically generated.
#python-list = $${}
#python-list = $${}
...
...
stack/cloudooo.cfg
View file @
9532a30b
...
@@ -36,7 +36,6 @@ extends =
...
@@ -36,7 +36,6 @@ extends =
../component/libreoffice-bin/buildout.cfg
../component/libreoffice-bin/buildout.cfg
../component/libpng/buildout.cfg
../component/libpng/buildout.cfg
../component/lxml-python/buildout.cfg
../component/lxml-python/buildout.cfg
../component/python-2.6/buildout.cfg
../component/python-2.7/buildout.cfg
../component/python-2.7/buildout.cfg
../component/xorg/buildout.cfg
../component/xorg/buildout.cfg
../component/fonts/buildout.cfg
../component/fonts/buildout.cfg
...
@@ -77,7 +76,6 @@ parts =
...
@@ -77,7 +76,6 @@ parts =
poppler
poppler
ffmpeg
ffmpeg
bootstrap2.6
rdiff-backup
rdiff-backup
cloudooo
cloudooo
...
@@ -85,9 +83,6 @@ parts =
...
@@ -85,9 +83,6 @@ parts =
develop +=
develop +=
${:parts-directory}/cloudooo
${:parts-directory}/cloudooo
[bootstrap2.6]
python = python2.6
[versions]
[versions]
# Use SlapOS patched zc.buildout
# Use SlapOS patched zc.buildout
zc.buildout = 1.6.0-dev-SlapOS-006
zc.buildout = 1.6.0-dev-SlapOS-006
stack/erp5/buildout.cfg
View file @
9532a30b
...
@@ -3,6 +3,8 @@
...
@@ -3,6 +3,8 @@
develop =
develop =
${:parts-directory}/slapos.cookbook-repository
${:parts-directory}/slapos.cookbook-repository
${:parts-directory}/cloudooo-repository
${:parts-directory}/cloudooo-repository
# not really just erp5-util but all erp5
${:parts-directory}/erp5.dev-repository
extensions =
extensions =
slapos.zcbworkarounds
slapos.zcbworkarounds
...
@@ -14,6 +16,8 @@ find-links =
...
@@ -14,6 +16,8 @@ find-links =
http://dist.repoze.org
http://dist.repoze.org
http://www.nexedi.org/static/packages/source/
http://www.nexedi.org/static/packages/source/
http://www.owlfish.com/software/wsgiutils/download.html
http://www.owlfish.com/software/wsgiutils/download.html
https://pypi.python.org/packages/source/z/z3c.etestbrowser/
https://pypi.python.org/packages/source/z/zope.testbrowser/
allow-hosts += pybrary.net
allow-hosts += pybrary.net
...
@@ -102,6 +106,8 @@ parts =
...
@@ -102,6 +106,8 @@ parts =
eggs
eggs
testrunner
testrunner
test_suite_runner
test_suite_runner
scalability_test_suite_runner
performance_tester
# basic Xorg
# basic Xorg
libXdmcp
libXdmcp
...
@@ -131,12 +137,38 @@ parts =
...
@@ -131,12 +137,38 @@ parts =
# Local development
# Local development
slapos.cookbook-repository
slapos.cookbook-repository
check-recipe
erp5.dev-repository
erp5.util
slapos.cookbook
slapos.cookbook
slapos.recipe.template
slapos.recipe.template
# Create instance template
# Create instance template
template
template
check-recipe
erp5.util-check
[erp5.dev-repository]
recipe = slapos.recipe.build:gitclone
repository = http://192.168.242.75:1235/erp5.git
branch = scalability-master2
git-executable = ${git:location}/bin/git
[erp5.util-check]
recipe = plone.recipe.command
stop-on-error = true
update-command = ${:command}
command = grep parts ${buildout:develop-eggs-directory}/erp5.util.egg-link
[erp5.util]
recipe = zc.recipe.egg
eggs = erp5.util
scripts =
ugly-depend-on = ${erp5.dev-repository:repository} ${erp5.dev-repository:branch}
[download-base]
[download-base]
recipe = slapos.recipe.build:download
recipe = slapos.recipe.build:download
url = ${:_profile_base_location_}/${:filename}
url = ${:_profile_base_location_}/${:filename}
...
@@ -423,6 +455,43 @@ initialization =
...
@@ -423,6 +455,43 @@ initialization =
repository_id_list = list(reversed('''${erp5_repository_list:repository_id_list}'''.split()))
repository_id_list = list(reversed('''${erp5_repository_list:repository_id_list}'''.split()))
sys.path[0:0] = ['/'.join(['''${buildout:parts-directory}''', x]) for x in repository_id_list]
sys.path[0:0] = ['/'.join(['''${buildout:parts-directory}''', x]) for x in repository_id_list]
[scalability_test_suite_runner]
recipe = zc.recipe.egg
eggs = ${eggs:eggs}
extra-paths = ${eggs:extra-paths}
entry-points =
runScalabilityTestSuite=erp5.util.scalability.runScalabilityTestSuite:main
scripts = runScalabilityTestSuite
initialization =
import os
import sys
import erp5.util
[Products.__path__.insert(0, p) for p in reversed(os.environ.get('INSERT_PRODUCTS_PATH', '').split(':')) if p]
import Zope2
os.environ['SOFTWARE_HOME'] = os.path.abspath(os.path.dirname(os.path.dirname(Zope2.__file__)))
os.environ['ZOPE_SCRIPTS'] = ''
repository_id_list = list(reversed('''${erp5_repository_list:repository_id_list}'''.split()))
sys.path[0:0] = ['/'.join(['''${buildout:parts-directory}''', x]) for x in repository_id_list]
[performance_tester]
recipe = zc.recipe.egg
eggs = ${eggs:eggs}
extra-paths = ${eggs:extra-paths}
entry-points =
performance_tester=erp5.util.benchmark.performance_tester:main
scripts = performance_tester
initialization =
import os
import sys
import erp5.util
[Products.__path__.insert(0, p) for p in reversed(os.environ.get('INSERT_PRODUCTS_PATH', '').split(':')) if p]
import Zope2
os.environ['SOFTWARE_HOME'] = os.path.abspath(os.path.dirname(os.path.dirname(Zope2.__file__)))
os.environ['ZOPE_SCRIPTS'] = ''
repository_id_list = list(reversed('''${erp5_repository_list:repository_id_list}'''.split()))
sys.path[0:0] = ['/'.join(['''${buildout:parts-directory}''', x]) for x in repository_id_list]
[eggs]
[eggs]
recipe = zc.recipe.egg
recipe = zc.recipe.egg
eggs =
eggs =
...
@@ -461,7 +530,7 @@ eggs =
...
@@ -461,7 +530,7 @@ eggs =
feedparser
feedparser
argparse
argparse
validictory
validictory
erp5.util
#
erp5.util
huBarcode
huBarcode
qrcode
qrcode
spyne
spyne
...
@@ -505,6 +574,15 @@ eggs =
...
@@ -505,6 +574,15 @@ eggs =
# Needed for parsing .po files from our Localizer subset
# Needed for parsing .po files from our Localizer subset
polib
polib
# performance_tester dependencies
z3c.etestbrowser
zope.testbrowser
# runScalabilityTestSuite dependencie
slapos.core
psutil
# parameterizing the version of the generated python interpreter name by the
# parameterizing the version of the generated python interpreter name by the
# python section version causes dependency between this egg section and the
# python section version causes dependency between this egg section and the
# installation of python, which we don't want on an instance
# installation of python, which we don't want on an instance
...
@@ -518,11 +596,12 @@ scripts =
...
@@ -518,11 +596,12 @@ scripts =
web_checker_utility = erp5.util.webchecker:web_checker_utility
web_checker_utility = erp5.util.webchecker:web_checker_utility
extra-paths =
extra-paths =
${erp5:location}
# ${erp5:location}
${erp5.dev-repository:location}
[zodbanalyze]
[zodbanalyze]
recipe = zc.recipe.egg
recipe = zc.recipe.egg
python = python2.
6
python = python2.
7
eggs =
eggs =
ZODB3
ZODB3
erp5.util
erp5.util
...
@@ -547,11 +626,19 @@ scripts =
...
@@ -547,11 +626,19 @@ scripts =
zodbpack
zodbpack
[cloudooo]
[cloudooo]
# cloudooo section tries to use python2.6, which doesn't exist anymore.
# cloudooo section tries to use python2.6, which doesn't exist anymore.
# Make it use 2.7 instead.
# Make it use 2.7 instead.
python = python2.7
python = python2.7
[versions]
[versions]
z3c.etestbrowser = 2.0.0
zope.testbrowser =
slapos.core = 0.32.3
psutil =
# pin Acquisition and Products.DCWorkflow to Nexedi flavour of eggs
# pin Acquisition and Products.DCWorkflow to Nexedi flavour of eggs
Acquisition = 2.13.7nxd001
Acquisition = 2.13.7nxd001
Products.DCWorkflow = 2.2.3nxd002
Products.DCWorkflow = 2.2.3nxd002
...
@@ -600,6 +687,16 @@ Products.CMFDefault = 2.2.2
...
@@ -600,6 +687,16 @@ Products.CMFDefault = 2.2.2
Products.CMFTopic = 2.2.1
Products.CMFTopic = 2.2.1
Products.CMFUid = 2.2.1
Products.CMFUid = 2.2.1
# newer version requires zope.traversing>=4.0.0a2.
zope.app.appsetup = 3.16.0
# newer version requires zope.i18n>=4.0.0a3
zope.app.publication = 3.14.0
# BBB: Temporarily keep zope.app.testing awaiting we use newer version of CMF
# (for tests like testCookieCrumbler).
zope.app.testing = 3.8.1
# Pinned versions
# Pinned versions
Flask = 0.9
Flask = 0.9
GitPython = 0.3.2.RC1
GitPython = 0.3.2.RC1
...
@@ -617,6 +714,7 @@ Products.LongRequestLogger = 1.1.0
...
@@ -617,6 +714,7 @@ Products.LongRequestLogger = 1.1.0
Products.MimetypesRegistry = 2.0.4
Products.MimetypesRegistry = 2.0.4
Products.PluginRegistry = 1.3
Products.PluginRegistry = 1.3
Products.TIDStorage = 5.4.8
Products.TIDStorage = 5.4.8
Products.ZSQLMethods = 2.13.4
Pygments = 1.6
Pygments = 1.6
StructuredText = 2.11.1
StructuredText = 2.11.1
WSGIUtils = 0.7
WSGIUtils = 0.7
...
@@ -631,10 +729,12 @@ coverage = 3.6
...
@@ -631,10 +729,12 @@ coverage = 3.6
csp-eventlet = 0.7.0
csp-eventlet = 0.7.0
elementtree = 1.2.7-20070827-preview
elementtree = 1.2.7-20070827-preview
erp5.recipe.cmmiforcei686 = 0.1.3
erp5.recipe.cmmiforcei686 = 0.1.3
erp5.util = 0.4.34
#erp5.util = 0.4.34
erp5.util =
erp5diff = 0.8.1.5
erp5diff = 0.8.1.5
eventlet = 0.12.1
eventlet = 0.12.1
feedparser = 5.1.3
feedparser = 5.1.3
five.formlib = 1.0.4
five.localsitemanager = 2.0.5
five.localsitemanager = 2.0.5
fpconst = 0.7.2
fpconst = 0.7.2
gitdb = 0.5.4
gitdb = 0.5.4
...
...
stack/erp5/instance-scalability.cfg.in
View file @
9532a30b
...
@@ -7,6 +7,7 @@ eggs-directory = {{ eggs_directory }}
...
@@ -7,6 +7,7 @@ eggs-directory = {{ eggs_directory }}
develop-eggs-directory = {{ develop_eggs_directory }}
develop-eggs-directory = {{ develop_eggs_directory }}
offline = true
offline = true
# Request erp5-cluster instance
[erp5-cluster]
[erp5-cluster]
recipe = slapos.cookbook:request.serialised
recipe = slapos.cookbook:request.serialised
sla = computer_guid
sla = computer_guid
...
@@ -25,24 +26,26 @@ config =
...
@@ -25,24 +26,26 @@ config =
extra-config =
extra-config =
config-use-ipv6 = {{ dumps(slapparameter_dict.get('use-ipv6', False)) }}
config-use-ipv6 = {{ dumps(slapparameter_dict.get('use-ipv6', False)) }}
[launcher-param]
binary-path = ${rootdirectory:bin}/launcher
wrapper-path = ${rootdirectory:bin}/launcher
log-path = ${basedirectory:log}/launcher.log
test-suite-title = {{ slapparameter_dict.get('test-suite-title', '') }}
# Create wrapper and execute command with parameters
[binary-wrap-launcher]
[binary-wrap-launcher]
recipe = slapos.cookbook:wrapper
recipe = slapos.cookbook:wrapper
command-line = "${launcher-param:binary-path} --test_suite_title ${launcher-param:test-suite-title} --log ${launcher-param:log-path}"
log-path = ${basedirectory:log}/runScalabilityTestSuite.log
output = ${launcher-param:binary-path}
binary-path = {{ bin_directory }}/runScalabilityTestSuite
wrapper-path = ${rootdirectory:bin}/runScalabilityTestSuite
output = ${binary-wrap-launcher:binary-path}
# TODO : get the erp5-cluster main url (apache listening user port ?)
erp5-url = http://foo.bar
# Run scalability test suite wrapper command with parameters
# -\ dirty way to conserve spaces
command-line = "${binary-wrap-launcher:binary-path}" --erp5-url ${binary-wrap-launcher:erp5-url} --test-result-path {{ slapparameter_dict.get('test-result-path') }} --revision {{ slapparameter_dict.get('revision') }} --node-title {{ slapparameter_dict.get('node-title') }} --test-suite-master-url {{ slapparameter_dict.get('test-suite-master-url') }} --log-path ${binary-wrap-launcher:log-path}
return = url
return = url
# Create partition's directories
[basedirectory]
[basedirectory]
recipe = slapos.cookbook:mkdirectory
recipe = slapos.cookbook:mkdirectory
log = ${rootdirectory:var}/log
log = ${rootdirectory:var}/log
run = ${rootdirectory:var}/run
services = ${rootdirectory:etc}/run
[rootdirectory]
[rootdirectory]
recipe = slapos.cookbook:mkdirectory
recipe = slapos.cookbook:mkdirectory
...
...
stack/erp5/instance.cfg.in
View file @
9532a30b
...
@@ -240,6 +240,18 @@ extra-context =
...
@@ -240,6 +240,18 @@ extra-context =
# Must match the key id in [switch-softwaretype] which uses this section.
# Must match the key id in [switch-softwaretype] which uses this section.
raw software_type cluster-zope
raw software_type cluster-zope
[dynamic-template-scalability]
< = jinja2-template-base
template = {{ template_scalability }}
filename = instance-scalability.cfg
extensions = jinja2.ext.do
bin_directory = {{ bin_directory }}
extra-context =
key bin_directory dynamic-template-scalability:bin_directory
key local_bt5_repository dynamic-template-cluster-erp5-parameters:local-bt5-repository
# Must match the key id in [switch-softwaretype] which uses this section.
raw software_type scalability
[dynamic-template-kumofs-parameters]
[dynamic-template-kumofs-parameters]
dash-location = {{ dash_location }}
dash-location = {{ dash_location }}
dcron-location = {{ dcron_location }}
dcron-location = {{ dcron_location }}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment