Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
S
sdkjs
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boris Kocherov
sdkjs
Commits
d504524c
Commit
d504524c
authored
Oct 10, 2016
by
GoshaZotov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
add rename column changes into history
parent
b48dbad6
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
52 additions
and
9 deletions
+52
-9
cell/model/History.js
cell/model/History.js
+1
-0
cell/model/UndoRedo.js
cell/model/UndoRedo.js
+23
-6
cell/model/autofilters.js
cell/model/autofilters.js
+28
-3
No files found.
cell/model/History.js
View file @
d504524c
...
@@ -142,6 +142,7 @@ function (window, undefined) {
...
@@ -142,6 +142,7 @@ function (window, undefined) {
window
[
'
AscCH
'
].
historyitem_AutoFilter_ChangeTableRef
=
13
;
window
[
'
AscCH
'
].
historyitem_AutoFilter_ChangeTableRef
=
13
;
window
[
'
AscCH
'
].
historyitem_AutoFilter_ChangeTableName
=
14
;
window
[
'
AscCH
'
].
historyitem_AutoFilter_ChangeTableName
=
14
;
window
[
'
AscCH
'
].
historyitem_AutoFilter_ClearFilterColumn
=
15
;
window
[
'
AscCH
'
].
historyitem_AutoFilter_ClearFilterColumn
=
15
;
window
[
'
AscCH
'
].
historyitem_AutoFilter_ChangeColumnName
=
16
;
function
CHistory
()
function
CHistory
()
...
...
cell/model/UndoRedo.js
View file @
d504524c
...
@@ -1763,8 +1763,10 @@ var g_oUndoRedoData_AutoFilterProperties = {
...
@@ -1763,8 +1763,10 @@ var g_oUndoRedoData_AutoFilterProperties = {
HeaderRowCount
:
15
,
HeaderRowCount
:
15
,
TotalsRowCount
:
16
,
TotalsRowCount
:
16
,
color
:
17
,
color
:
17
,
tablePart
:
18
tablePart
:
18
,
};
nCol
:
19
,
nRow
:
20
};
function
UndoRedoData_AutoFilter
()
{
function
UndoRedoData_AutoFilter
()
{
this
.
Properties
=
g_oUndoRedoData_AutoFilterProperties
;
this
.
Properties
=
g_oUndoRedoData_AutoFilterProperties
;
...
@@ -1791,6 +1793,8 @@ function UndoRedoData_AutoFilter() {
...
@@ -1791,6 +1793,8 @@ function UndoRedoData_AutoFilter() {
this
.
TotalsRowCount
=
null
;
this
.
TotalsRowCount
=
null
;
this
.
color
=
null
;
this
.
color
=
null
;
this
.
tablePart
=
null
;
this
.
tablePart
=
null
;
this
.
nCol
=
null
;
this
.
nRow
=
null
;
}
}
UndoRedoData_AutoFilter
.
prototype
=
{
UndoRedoData_AutoFilter
.
prototype
=
{
getType
:
function
()
getType
:
function
()
...
@@ -1836,6 +1840,8 @@ UndoRedoData_AutoFilter.prototype = {
...
@@ -1836,6 +1840,8 @@ UndoRedoData_AutoFilter.prototype = {
return
tablePart
;
break
;
return
tablePart
;
break
;
}
}
case
this
.
Properties
.
nCol
:
return
this
.
nCol
;
break
;
case
this
.
Properties
.
nRow
:
return
this
.
nRow
;
break
;
}
}
return
null
;
return
null
;
...
@@ -1897,6 +1903,8 @@ UndoRedoData_AutoFilter.prototype = {
...
@@ -1897,6 +1903,8 @@ UndoRedoData_AutoFilter.prototype = {
}
}
break
;
break
;
}
}
case
this
.
Properties
.
nCol
:
this
.
nCol
=
value
;
break
;
case
this
.
Properties
.
nRow
:
this
.
nRow
=
value
;
break
;
}
}
return
null
;
return
null
;
},
},
...
@@ -3136,8 +3144,6 @@ UndoRedoCell.prototype = {
...
@@ -3136,8 +3144,6 @@ UndoRedoCell.prototype = {
{
{
if
(
bUndo
||
AscCH
.
historyitem_Cell_ChangeValueUndo
!==
Type
)
{
if
(
bUndo
||
AscCH
.
historyitem_Cell_ChangeValueUndo
!==
Type
)
{
cell
.
setValueData
(
Val
);
cell
.
setValueData
(
Val
);
// ToDo Так делать неправильно, нужно поправить (перенести логику в model, а отрисовку отделить)
ws
.
autoFilters
.
renameTableColumn
(
new
Asc
.
Range
(
nCol
,
nRow
,
nCol
,
nRow
),
bUndo
);
}
}
}
}
else
if
(
AscCH
.
historyitem_Cell_SetStyle
==
Type
)
else
if
(
AscCH
.
historyitem_Cell_SetStyle
==
Type
)
...
@@ -3872,13 +3878,24 @@ UndoRedoAutoFilters.prototype = {
...
@@ -3872,13 +3878,24 @@ UndoRedoAutoFilters.prototype = {
var
ws
=
wb
.
getWorksheetById
(
nSheetId
);
var
ws
=
wb
.
getWorksheetById
(
nSheetId
);
if
(
ws
){
if
(
ws
){
var
autoFilters
=
ws
.
autoFilters
;
var
autoFilters
=
ws
.
autoFilters
;
if
(
bUndo
==
true
)
if
(
bUndo
==
=
true
)
{
{
autoFilters
.
Undo
(
Type
,
Data
);
autoFilters
.
Undo
(
Type
,
Data
);
}
}
else
else
{
if
(
AscCH
.
historyitem_AutoFilter_ChangeColumnName
===
Type
)
{
if
(
false
!=
this
.
wb
.
bCollaborativeChanges
)
{
var
collaborativeEditing
=
this
.
wb
.
oApi
.
collaborativeEditing
;
Data
.
nRow
=
collaborativeEditing
.
getLockOtherRow2
(
nSheetId
,
Data
.
nRow
);
Data
.
nCol
=
collaborativeEditing
.
getLockOtherColumn2
(
nSheetId
,
Data
.
nCol
);
}
}
autoFilters
.
Redo
(
Type
,
Data
);
autoFilters
.
Redo
(
Type
,
Data
);
}
}
}
},
},
forwardTransformationIsAffect
:
function
(
Type
)
{
forwardTransformationIsAffect
:
function
(
Type
)
{
return
AscCH
.
historyitem_AutoFilter_Add
===
Type
||
AscCH
.
historyitem_AutoFilter_ChangeTableName
===
Type
||
return
AscCH
.
historyitem_AutoFilter_Add
===
Type
||
AscCH
.
historyitem_AutoFilter_ChangeTableName
===
Type
||
...
...
cell/model/autofilters.js
View file @
d504524c
...
@@ -896,6 +896,9 @@
...
@@ -896,6 +896,9 @@
case
AscCH
.
historyitem_AutoFilter_ClearFilterColumn
:
case
AscCH
.
historyitem_AutoFilter_ClearFilterColumn
:
this
.
clearFilterColumn
(
data
.
cellId
,
data
.
displayName
);
this
.
clearFilterColumn
(
data
.
cellId
,
data
.
displayName
);
break
;
break
;
case
AscCH
.
historyitem_AutoFilter_ChangeColumnName
:
this
.
renameTableColumn
(
null
,
null
,
data
);
break
;
}
}
History
.
TurnOn
();
History
.
TurnOn
();
},
},
...
@@ -923,7 +926,11 @@
...
@@ -923,7 +926,11 @@
delete
cloneData
.
insCells
;
delete
cloneData
.
insCells
;
//TODO переделать undo, по типам
//TODO переделать undo, по типам
if
(
type
===
AscCH
.
historyitem_AutoFilter_Move
)
//перемещение
if
(
type
===
AscCH
.
historyitem_AutoFilter_ChangeColumnName
)
//перемещение
{
this
.
renameTableColumn
(
null
,
null
,
undoData
);
}
else
if
(
type
===
AscCH
.
historyitem_AutoFilter_Move
)
//перемещение
{
{
this
.
_moveAutoFilters
(
null
,
null
,
data
);
this
.
_moveAutoFilters
(
null
,
null
,
data
);
}
}
...
@@ -2829,6 +2836,8 @@
...
@@ -2829,6 +2836,8 @@
oHistoryObject
.
val
=
redoObject
.
val
;
oHistoryObject
.
val
=
redoObject
.
val
;
oHistoryObject
.
color
=
redoObject
.
color
;
oHistoryObject
.
color
=
redoObject
.
color
;
oHistoryObject
.
tablePart
=
redoObject
.
tablePart
;
oHistoryObject
.
tablePart
=
redoObject
.
tablePart
;
oHistoryObject
.
nCol
=
redoObject
.
nCol
;
oHistoryObject
.
nRow
=
redoObject
.
nRow
;
}
}
else
else
{
{
...
@@ -2850,7 +2859,7 @@
...
@@ -2850,7 +2859,7 @@
return
ws
.
model
;
return
ws
.
model
;
},
},
renameTableColumn
:
function
(
range
,
bUndo
)
renameTableColumn
:
function
(
range
,
bUndo
,
props
)
{
{
var
worksheet
=
this
.
worksheet
;
var
worksheet
=
this
.
worksheet
;
var
val
;
var
val
;
...
@@ -2876,6 +2885,11 @@
...
@@ -2876,6 +2885,11 @@
return
res
;
return
res
;
};
};
if
(
props
)
{
range
=
new
Asc
.
Range
(
props
.
nCol
,
props
.
nRow
,
props
.
nCol
,
props
.
nRow
);
}
if
(
worksheet
.
TableParts
)
if
(
worksheet
.
TableParts
)
{
{
worksheet
.
workbook
.
dependencyFormulas
.
buildDependency
();
worksheet
.
workbook
.
dependencyFormulas
.
buildDependency
();
...
@@ -2898,7 +2912,7 @@
...
@@ -2898,7 +2912,7 @@
continue
;
continue
;
cell
=
worksheet
.
getCell3
(
ref
.
r1
,
j
);
cell
=
worksheet
.
getCell3
(
ref
.
r1
,
j
);
val
=
cell
.
getValue
();
val
=
props
?
props
.
val
:
cell
.
getValue
();
//проверка на повторение уже существующих заголовков
//проверка на повторение уже существующих заголовков
if
(
checkRepeateColumnName
(
val
,
filter
.
TableColumns
,
j
-
tableRange
.
c1
))
if
(
checkRepeateColumnName
(
val
,
filter
.
TableColumns
,
j
-
tableRange
.
c1
))
...
@@ -2907,12 +2921,17 @@
...
@@ -2907,12 +2921,17 @@
}
}
//если не пустая изменяем TableColumns
//если не пустая изменяем TableColumns
var
oldVal
=
filter
.
TableColumns
[
j
-
tableRange
.
c1
].
Name
;
var
newVal
=
null
;
if
(
val
!=
""
&&
intersection
.
c1
<=
j
&&
intersection
.
c2
>=
j
)
if
(
val
!=
""
&&
intersection
.
c1
<=
j
&&
intersection
.
c2
>=
j
)
{
{
filter
.
TableColumns
[
j
-
tableRange
.
c1
].
Name
=
val
;
filter
.
TableColumns
[
j
-
tableRange
.
c1
].
Name
=
val
;
if
(
!
bUndo
)
if
(
!
bUndo
)
{
cell
.
setType
(
CellValueType
.
String
);
cell
.
setType
(
CellValueType
.
String
);
}
}
newVal
=
val
;
}
else
if
(
val
==
""
)
//если пустая изменяем генерируем имя и добавляем его в TableColumns
else
if
(
val
==
""
)
//если пустая изменяем генерируем имя и добавляем его в TableColumns
{
{
filter
.
TableColumns
[
j
-
tableRange
.
c1
].
Name
=
""
;
filter
.
TableColumns
[
j
-
tableRange
.
c1
].
Name
=
""
;
...
@@ -2923,6 +2942,12 @@
...
@@ -2923,6 +2942,12 @@
cell
.
setType
(
CellValueType
.
String
);
cell
.
setType
(
CellValueType
.
String
);
}
}
filter
.
TableColumns
[
j
-
tableRange
.
c1
].
Name
=
generateName
;
filter
.
TableColumns
[
j
-
tableRange
.
c1
].
Name
=
generateName
;
newVal
=
generateName
;
}
if
(
null
!==
newVal
)
{
this
.
_addHistoryObj
({
nCol
:
cell
.
bbox
.
c1
,
nRow
:
cell
.
bbox
.
r1
,
val
:
oldVal
},
AscCH
.
historyitem_AutoFilter_ChangeColumnName
,
{
activeCells
:
range
,
nCol
:
cell
.
bbox
.
c1
,
nRow
:
cell
.
bbox
.
r1
,
val
:
newVal
});
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment