PID controller, derivative filtering modified, and function object Filter...

PID controller, derivative filtering modified, and function object Filter filter algorithm  modified

src/lib/rt/src/rt_plc_arithm.c

@@ -352,11 +352,14 @@ void filter_exec(
   plc_sThread		*tp,
   pwr_sClass_filter 	*object)
 {
+	float kd;
+	
 	object->In = *object->InP;
-	if (object->FiltCon > *object->ScanTime)
+	if (object->FiltCon > 0.0) {
+	  kd = 1.0 / (1.0 + *object->ScanTime / object->FiltCon);
 	  object->ActVal = *object->FeedBP +
-	    (object->In - *object->FeedBP) * *object->ScanTime / object->FiltCon;
-	else
+	    (object->In - *object->FeedBP) * (1.0 - kd);
+	} else
 	  object->ActVal = object->In;
 }
 

src/lib/rt/src/rt_plc_pid.c

@@ -338,6 +338,9 @@ void mode_exec(
 		Possible to turn off integration and to force
 		output to desired value.
 		
+  Revision:	2011-01-18 / Werner
+		Error in filtered derivate part corrected.
+		
   @aref pid Pid
 */
 
@@ -360,6 +363,7 @@ void pid_exec(
 	float	derold;
 	float	ut;
 	float	dut;
+	float	kd;
 
 /* Save old values */
 xold=object->ProcVal;
@@ -381,12 +385,12 @@ object->ControlDiff = object->ProcVal - object->SetVal;
 ddiff = ((object->PidAlg & DAVV) != 0) ?
   (object->ControlDiff - eold) / *object->ScanTime:
   (object->ProcVal - xold) / *object->ScanTime;
-if ((object->DerGain < 1.0) ||
-    (object->DerGain * *object->ScanTime >= object->DerTime))
-    object->FiltDer = ddiff * object->DerTime;		/* No Filter */
-else
-    object->FiltDer += (ddiff - derold) *
-      object->DerGain * *object->ScanTime; /* Filter */
+if ((object->DerGain <= 0.0) || (object->DerTime <= 0))
+    object->FiltDer = ddiff;		/* No Filter */
+else {
+    kd = 1.0 / (1.0 + object->DerGain * *object->ScanTime / object->DerTime);
+    object->FiltDer += (ddiff - derold) * (1.0 - kd);
+}
 
 if ( object->Force )
 /* Force */
@@ -414,7 +418,7 @@ else
     {
       /* Derivative-part */
       if ((object->PidAlg & DALG) != 0)
-        dut += (object->FiltDer-derold);
+        dut += (object->FiltDer-derold) * object->DerTime;
       /* P-part */
       dut += ((object->PidAlg & PAVV) != 0) ?
         object->ControlDiff - eold :
@@ -457,7 +461,7 @@ else
     ut = object->ControlDiff;
     /* Derivative-part */
     if ((object->PidAlg & DALG) != 0)
-      ut += object->FiltDer;
+      ut += object->FiltDer * object->DerTime;
     /* Gain */
     ut *= object->Gain;
     if (object->Inverse != 0) ut = - ut;

src/wbl/pwrb/src/pwrb_c_filter.wb_load

@@ -34,8 +34,7 @@ SObject pwrb:Class
 !      X =  FeedB, if FeedB is connected, 
 !           ActValt - 1, otherwise
 !  
-!    a = ScanTime / FiltCon and 0 < a < 1.0. 
-!    If a >= 1.0 no filtering is done.
+!    a = 1 - 1 / (1 + ScanTime / FiltCon)
 !
 !  An external signal may also be used as feedback; e.g.
 !  @image orm_en1-77.gif