angularjs: simplify clearCompleted method

* Remove unused `completeTodos` variable * use `Array#filter` instead of `Array#forEach`

angularjs: simplify clearCompleted method
* Remove unused `completeTodos` variable * use `Array#filter` instead of `Array#forEach`
e856cd47 · David Runger · 44053122 · e856cd47
Commit e856cd47 authored Nov 09, 2015 by David Runger
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 16 deletions

examples/angularjs/js/services/todoStorage.js examples/angularjs/js/services/todoStorage.js +4 -16

No files found.
--- a/examples/angularjs/js/services/todoStorage.js
+++ b/examples/angularjs/js/services/todoStorage.js
@@ -36,14 +36,8 @@ angular.module('todomvc')
 			clearCompleted: function () {
 				var originalTodos = store.todos.slice(0);
-				var completeTodos = [];
+				var incompleteTodos = store.todos.filter(function (todo) {
-				var incompleteTodos = [];
+					return !todo.completed;
-				store.todos.forEach(function (todo) {
-					if (todo.completed) {
-						completeTodos.push(todo);
-					} else {
-						incompleteTodos.push(todo);
-					}
 				});
 				angular.copy(incompleteTodos, store.todos);
@@ -112,14 +106,8 @@ angular.module('todomvc')
 			clearCompleted: function () {
 				var deferred = $q.defer();
-				var completeTodos = [];
+				var incompleteTodos = store.todos.filter(function (todo) {
-				var incompleteTodos = [];
+					return !todo.completed;
-				store.todos.forEach(function (todo) {
-					if (todo.completed) {
-						completeTodos.push(todo);
-					} else {
-						incompleteTodos.push(todo);
-					}
 				});
 				angular.copy(incompleteTodos, store.todos);