Commit e8f8532b authored by Pascal Hartig's avatar Pascal Hartig

Merge pull request #881 from dprotti/gwtusesetdisplay

gwt - improvement: use setDisplay()
parents 938e3b56 4cc496fd
...@@ -4,6 +4,7 @@ import com.google.gwt.core.client.GWT; ...@@ -4,6 +4,7 @@ import com.google.gwt.core.client.GWT;
import com.google.gwt.dom.client.Element; import com.google.gwt.dom.client.Element;
import com.google.gwt.dom.client.InputElement; import com.google.gwt.dom.client.InputElement;
import com.google.gwt.dom.client.SpanElement; import com.google.gwt.dom.client.SpanElement;
import com.google.gwt.dom.client.Style.Display;
import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.dom.client.KeyCodes; import com.google.gwt.event.dom.client.KeyCodes;
...@@ -142,9 +143,9 @@ public class ToDoView extends Composite implements ToDoPresenter.View { ...@@ -142,9 +143,9 @@ public class ToDoView extends Composite implements ToDoPresenter.View {
public void setTaskStatistics(int totalTasks, int completedTasks) { public void setTaskStatistics(int totalTasks, int completedTasks) {
int remainingTasks = totalTasks - completedTasks; int remainingTasks = totalTasks - completedTasks;
hideElement(mainSection, totalTasks == 0); displayOrHide(mainSection, totalTasks == 0);
hideElement(todoStatsContainer, totalTasks == 0); displayOrHide(todoStatsContainer, totalTasks == 0);
hideElement(clearCompleted.getElement(), completedTasks == 0); displayOrHide(clearCompleted.getElement(), completedTasks == 0);
remainingTasksCount.setInnerText(Integer.toString(remainingTasks)); remainingTasksCount.setInnerText(Integer.toString(remainingTasks));
remainingTasksLabel.setInnerText(remainingTasks > 1 || remainingTasks == 0 ? "items" : "item"); remainingTasksLabel.setInnerText(remainingTasks > 1 || remainingTasks == 0 ? "items" : "item");
...@@ -169,11 +170,11 @@ public class ToDoView extends Composite implements ToDoPresenter.View { ...@@ -169,11 +170,11 @@ public class ToDoView extends Composite implements ToDoPresenter.View {
} }
} }
private void hideElement(Element element, boolean hide) { private void displayOrHide(Element element, boolean hide) {
if (hide) { if (hide) {
element.setAttribute("style", "display:none;"); element.getStyle().setDisplay(Display.NONE);
} else { } else {
element.setAttribute("style", "display:block;"); element.getStyle().setDisplay(Display.BLOCK);
} }
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment