Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Gwenaël Samain
cython
Commits
6075a3c6
Commit
6075a3c6
authored
Apr 29, 2013
by
Stefan Behnel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix negative-index warning on empty slices
parent
47c41a3f
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
29 additions
and
16 deletions
+29
-16
Cython/Compiler/ExprNodes.py
Cython/Compiler/ExprNodes.py
+7
-7
tests/errors/wraparound_warnings.pyx
tests/errors/wraparound_warnings.pyx
+22
-9
No files found.
Cython/Compiler/ExprNodes.py
View file @
6075a3c6
...
...
@@ -106,10 +106,10 @@ def check_negative_indices(*nodes):
Used to find (potential) bugs inside of "wraparound=False" sections.
"""
for
node
in
nodes
:
if
not
isinstance
(
node
.
constant_result
,
(
int
,
float
,
long
)):
continue
if
node
.
constant_result
>=
0
:
if
(
node
is
None
or
not
isinstance
(
node
.
constant_result
,
(
int
,
float
,
long
))):
continue
if
node
.
constant_result
<
0
:
warning
(
node
.
pos
,
"the result of using negative indices inside of "
"code sections marked as 'wraparound=False' is "
...
...
tests/errors/wraparound_warnings.pyx
View file @
6075a3c6
...
...
@@ -7,13 +7,18 @@ s = "abc"
l
=
[
1
,
2
,
3
]
def
normal_wraparound
(
int
i
,
bytes
B
not
None
,
list
L
not
None
):
a
=
s
[:]
a
=
s
[
1
:
2
]
a
=
s
[
-
2
:
-
1
]
a
=
"abc"
[
-
2
:
-
1
]
a
=
"abc"
[
-
2
:
i
]
a
=
B
[
-
2
:
-
1
]
a
=
B
[:
-
1
]
a
=
B
[
-
2
:]
b
=
l
[
1
:
2
]
b
=
l
[:
2
]
b
=
l
[
1
:]
b
=
l
[
-
2
:
-
1
]
b
=
[
1
,
2
,
3
][
-
2
:
-
1
]
b
=
[
1
,
2
,
3
][
-
2
:
i
]
...
...
@@ -21,27 +26,35 @@ def normal_wraparound(int i, bytes B not None, list L not None):
@
cython
.
wraparound
(
False
)
def
no_wraparound
(
int
i
,
bytes
B
not
None
,
list
L
not
None
):
a
=
s
[:]
a
=
s
[
1
:
2
]
a
=
s
[
-
2
:
-
1
]
a
=
"abc"
[
-
2
:
-
1
]
a
=
"abc"
[
-
2
:
-
1
]
# evaluated at compile time
a
=
"abc"
[
-
2
:
i
]
a
=
B
[:]
a
=
B
[
-
2
:
-
1
]
a
=
B
[:
-
1
]
a
=
B
[
-
2
:]
b
=
l
[
1
:
2
]
b
=
l
[:
2
]
b
=
l
[
1
:]
b
=
l
[
-
2
:
-
1
]
b
=
[
1
,
2
,
3
][
-
2
:
i
]
b
=
L
[
-
2
:
-
1
]
_ERRORS
=
"""
25:11: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
25:14: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
27:15: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
28:11: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
28:14: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
31:11: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
31:14: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
32:19: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
33:11: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
33:14: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
33:15: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
35:11: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
35:14: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
36:12: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
37:11: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
42:11: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
42:14: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
43:19: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
44:11: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
44:14: the result of using negative indices inside of code sections marked as 'wraparound=False' is undefined
"""
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment