Commit 3c1db12c authored by Julien Muchembled's avatar Julien Muchembled

Clarify MovementGeneratorMixin._getUpdatePropertyDict

git-svn-id: https://svn.erp5.org/repos/public/erp5/sandbox/amount_generator@37611 20353a03-c40f-0410-a6d1-a30d3c3de9de
parent 800f68bf
...@@ -120,9 +120,10 @@ class MovementGeneratorMixin: ...@@ -120,9 +120,10 @@ class MovementGeneratorMixin:
return result return result
def _getUpdatePropertyDict(self, input_movement): def _getUpdatePropertyDict(self, input_movement):
# Default implementation bellow can be overriden by subclasses # XXX Wouldn't it better to return {} or {'delivery': None} ?
return {'delivery': input_movement.getRelativeUrl(), # XXX-JPS empty is better # Below code is mainly for root applied rules.
} # Other movement generators usually want to reset delivery.
return {'delivery': input_movement.getRelativeUrl()}
def _getTradePhaseList(self, input_movement, business_process): # XXX-JPS WEIRD def _getTradePhaseList(self, input_movement, business_process): # XXX-JPS WEIRD
movement_trade_phase = input_movement.getTradePhaseList() movement_trade_phase = input_movement.getTradePhaseList()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment