Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
iv
gitlab-ce
Commits
0e613db7
Commit
0e613db7
authored
Apr 26, 2016
by
Grzegorz Bizon
Committed by
Robert Speicher
May 29, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add more validation tests for note model
parent
57b551a1
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
27 additions
and
0 deletions
+27
-0
spec/models/note_spec.rb
spec/models/note_spec.rb
+27
-0
No files found.
spec/models/note_spec.rb
View file @
0e613db7
...
@@ -12,6 +12,33 @@ describe Note, models: true do
...
@@ -12,6 +12,33 @@ describe Note, models: true do
describe
'validation'
do
describe
'validation'
do
it
{
is_expected
.
to
validate_presence_of
(
:note
)
}
it
{
is_expected
.
to
validate_presence_of
(
:note
)
}
it
{
is_expected
.
to
validate_presence_of
(
:project
)
}
it
{
is_expected
.
to
validate_presence_of
(
:project
)
}
context
'when note is comment on commit'
do
before
{
allow
(
subject
).
to
receive
(
:for_commit?
).
and_return
(
true
)
}
it
{
is_expected
.
to
validate_presence_of
(
:commit_id
)
}
it
{
is_expected
.
to_not
validate_presence_of
(
:noteable_id
)
}
end
context
'when note is not comment on commit'
do
before
{
allow
(
subject
).
to
receive
(
:for_commit?
).
and_return
(
false
)
}
it
{
is_expected
.
to_not
validate_presence_of
(
:commit_id
)
}
it
{
is_expected
.
to
validate_presence_of
(
:noteable_id
)
}
end
context
'when noteable and note project is different'
do
subject
do
build
(
:note
,
noteable:
create
(
:issue
),
project:
create
(
:project
))
end
it
{
is_expected
.
to
be_invalid
}
end
context
'when noteable and note project is the same one'
do
subject
{
create
(
:note
)
}
it
{
is_expected
.
to
be_valid
}
end
end
end
describe
"Commit notes"
do
describe
"Commit notes"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment