Merge branch 'metrics-milliseconds' into 'master'

See merge request !2316

lib/gitlab/metrics/subscribers/action_view.rb

@@ -19,7 +19,7 @@ module Gitlab
           values = values_for(event)
           tags   = tags_for(event)
 
-          current_transaction.increment(:view_duration, event.duration)
+          current_transaction.increment(:view_duration, duration(event))
           current_transaction.add_metric(SERIES, values, tags)
         end
 
@@ -28,7 +28,7 @@ module Gitlab
         end
 
         def values_for(event)
-          { duration: event.duration }
+          { duration: duration(event) }
         end
 
         def tags_for(event)
@@ -48,6 +48,10 @@ module Gitlab
         def current_transaction
           Transaction.current
         end
+
+        def duration(event)
+          event.duration * 1000.0
+        end
       end
     end
   end

lib/gitlab/metrics/subscribers/active_record.rb

@@ -8,7 +8,7 @@ module Gitlab
         def sql(event)
           return unless current_transaction
 
-          current_transaction.increment(:sql_duration, event.duration)
+          current_transaction.increment(:sql_duration, duration(event))
         end
 
         private
@@ -16,6 +16,10 @@ module Gitlab
         def current_transaction
           Transaction.current
         end
+
+        def duration(event)
+          event.duration * 1000.0
+        end
       end
     end
   end

spec/lib/gitlab/metrics/subscribers/action_view_spec.rb

@@ -21,7 +21,7 @@ describe Gitlab::Metrics::Subscribers::ActionView do
 
   describe '#render_template' do
     it 'tracks rendering of a template' do
-      values = { duration: 2.1 }
+      values = { duration: 2100 }
       tags   = {
         view: 'app/views/x.html.haml',
         file: 'app/views/x.html.haml',
@@ -29,7 +29,7 @@ describe Gitlab::Metrics::Subscribers::ActionView do
       }
 
       expect(transaction).to receive(:increment).
-        with(:view_duration, 2.1)
+        with(:view_duration, 2100)
 
       expect(transaction).to receive(:add_metric).
         with(described_class::SERIES, values, tags)

spec/lib/gitlab/metrics/subscribers/active_record_spec.rb

@@ -26,7 +26,7 @@ describe Gitlab::Metrics::Subscribers::ActiveRecord do
           and_return(transaction)
 
         expect(transaction).to receive(:increment).
-          with(:sql_duration, 0.2)
+          with(:sql_duration, 200)
 
         subscriber.sql(event)
       end