Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
1536c69f
Commit
1536c69f
authored
Apr 19, 2018
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Convert fixTitle to _fixTitle for regenerating tooltip titles
parent
a3bc692e
Changes
13
Show whitespace changes
Inline
Side-by-side
Showing
13 changed files
with
16 additions
and
16 deletions
+16
-16
app/assets/javascripts/awards_handler.js
app/assets/javascripts/awards_handler.js
+2
-2
app/assets/javascripts/behaviors/copy_to_clipboard.js
app/assets/javascripts/behaviors/copy_to_clipboard.js
+2
-2
app/assets/javascripts/blob/viewer/index.js
app/assets/javascripts/blob/viewer/index.js
+1
-1
app/assets/javascripts/compare_autocomplete.js
app/assets/javascripts/compare_autocomplete.js
+1
-1
app/assets/javascripts/diff_notes/components/diff_note_avatars.js
...ts/javascripts/diff_notes/components/diff_note_avatars.js
+2
-2
app/assets/javascripts/diff_notes/components/resolve_btn.js
app/assets/javascripts/diff_notes/components/resolve_btn.js
+1
-1
app/assets/javascripts/labels_select.js
app/assets/javascripts/labels_select.js
+1
-1
app/assets/javascripts/lib/utils/common_utils.js
app/assets/javascripts/lib/utils/common_utils.js
+1
-1
app/assets/javascripts/project_label_subscription.js
app/assets/javascripts/project_label_subscription.js
+1
-1
app/assets/javascripts/right_sidebar.js
app/assets/javascripts/right_sidebar.js
+1
-1
app/assets/javascripts/users_select.js
app/assets/javascripts/users_select.js
+1
-1
app/assets/javascripts/vue_shared/directives/tooltip.js
app/assets/javascripts/vue_shared/directives/tooltip.js
+1
-1
doc/development/fe_guide/style_guide_js.md
doc/development/fe_guide/style_guide_js.md
+1
-1
No files found.
app/assets/javascripts/awards_handler.js
View file @
1536c69f
...
@@ -392,7 +392,7 @@ class AwardsHandler {
...
@@ -392,7 +392,7 @@ class AwardsHandler {
.
removeAttr
(
'
data-title
'
)
.
removeAttr
(
'
data-title
'
)
.
removeAttr
(
'
data-original-title
'
)
.
removeAttr
(
'
data-original-title
'
)
.
attr
(
'
title
'
,
this
.
toSentence
(
authors
))
.
attr
(
'
title
'
,
this
.
toSentence
(
authors
))
.
tooltip
(
'
fixTitle
'
);
.
tooltip
(
'
_
fixTitle
'
);
}
}
addYouToUserList
(
votesBlock
,
emoji
)
{
addYouToUserList
(
votesBlock
,
emoji
)
{
...
@@ -405,7 +405,7 @@ class AwardsHandler {
...
@@ -405,7 +405,7 @@ class AwardsHandler {
users
.
unshift
(
'
You
'
);
users
.
unshift
(
'
You
'
);
return
awardBlock
return
awardBlock
.
attr
(
'
title
'
,
this
.
toSentence
(
users
))
.
attr
(
'
title
'
,
this
.
toSentence
(
users
))
.
tooltip
(
'
fixTitle
'
);
.
tooltip
(
'
_
fixTitle
'
);
}
}
createAwardButtonForVotesBlock
(
votesBlock
,
emojiName
)
{
createAwardButtonForVotesBlock
(
votesBlock
,
emojiName
)
{
...
...
app/assets/javascripts/behaviors/copy_to_clipboard.js
View file @
1536c69f
...
@@ -8,10 +8,10 @@ function showTooltip(target, title) {
...
@@ -8,10 +8,10 @@ function showTooltip(target, title) {
if
(
!
$target
.
data
(
'
hideTooltip
'
))
{
if
(
!
$target
.
data
(
'
hideTooltip
'
))
{
$target
$target
.
attr
(
'
title
'
,
title
)
.
attr
(
'
title
'
,
title
)
.
tooltip
(
'
fixTitle
'
)
.
tooltip
(
'
_
fixTitle
'
)
.
tooltip
(
'
show
'
)
.
tooltip
(
'
show
'
)
.
attr
(
'
title
'
,
originalTitle
)
.
attr
(
'
title
'
,
originalTitle
)
.
tooltip
(
'
fixTitle
'
);
.
tooltip
(
'
_
fixTitle
'
);
}
}
}
}
...
...
app/assets/javascripts/blob/viewer/index.js
View file @
1536c69f
...
@@ -116,7 +116,7 @@ export default class BlobViewer {
...
@@ -116,7 +116,7 @@ export default class BlobViewer {
this
.
copySourceBtn
.
classList
.
add
(
'
disabled
'
);
this
.
copySourceBtn
.
classList
.
add
(
'
disabled
'
);
}
}
$
(
this
.
copySourceBtn
).
tooltip
(
'
fixTitle
'
);
$
(
this
.
copySourceBtn
).
tooltip
(
'
_
fixTitle
'
);
}
}
switchToViewer
(
name
)
{
switchToViewer
(
name
)
{
...
...
app/assets/javascripts/compare_autocomplete.js
View file @
1536c69f
...
@@ -57,7 +57,7 @@ export default function initCompareAutocomplete() {
...
@@ -57,7 +57,7 @@ export default function initCompareAutocomplete() {
$dropdownContainer
.
on
(
'
click
'
,
'
.dropdown-content a
'
,
(
e
)
=>
{
$dropdownContainer
.
on
(
'
click
'
,
'
.dropdown-content a
'
,
(
e
)
=>
{
$dropdown
.
prop
(
'
title
'
,
e
.
target
.
text
.
replace
(
/_+
?
/g
,
'
-
'
));
$dropdown
.
prop
(
'
title
'
,
e
.
target
.
text
.
replace
(
/_+
?
/g
,
'
-
'
));
if
(
$dropdown
.
hasClass
(
'
has-tooltip
'
))
{
if
(
$dropdown
.
hasClass
(
'
has-tooltip
'
))
{
$dropdown
.
tooltip
(
'
fixTitle
'
);
$dropdown
.
tooltip
(
'
_
fixTitle
'
);
}
}
});
});
});
});
...
...
app/assets/javascripts/diff_notes/components/diff_note_avatars.js
View file @
1536c69f
...
@@ -79,7 +79,7 @@ const DiffNoteAvatars = Vue.extend({
...
@@ -79,7 +79,7 @@ const DiffNoteAvatars = Vue.extend({
storeState
:
{
storeState
:
{
handler
()
{
handler
()
{
this
.
$nextTick
(()
=>
{
this
.
$nextTick
(()
=>
{
$
(
'
.has-tooltip
'
,
this
.
$el
).
tooltip
(
'
fixTitle
'
);
$
(
'
.has-tooltip
'
,
this
.
$el
).
tooltip
(
'
_
fixTitle
'
);
// We need to add/remove a class to an element that is outside the Vue instance
// We need to add/remove a class to an element that is outside the Vue instance
this
.
addNoCommentClass
();
this
.
addNoCommentClass
();
...
@@ -138,7 +138,7 @@ const DiffNoteAvatars = Vue.extend({
...
@@ -138,7 +138,7 @@ const DiffNoteAvatars = Vue.extend({
this
.
$nextTick
(()
=>
{
this
.
$nextTick
(()
=>
{
this
.
setDiscussionVisible
();
this
.
setDiscussionVisible
();
$
(
'
.has-tooltip
'
,
this
.
$el
).
tooltip
(
'
fixTitle
'
);
$
(
'
.has-tooltip
'
,
this
.
$el
).
tooltip
(
'
_
fixTitle
'
);
$
(
'
.has-tooltip
'
,
this
.
$el
).
tooltip
(
'
hide
'
);
$
(
'
.has-tooltip
'
,
this
.
$el
).
tooltip
(
'
hide
'
);
});
});
},
},
...
...
app/assets/javascripts/diff_notes/components/resolve_btn.js
View file @
1536c69f
...
@@ -61,7 +61,7 @@ const ResolveBtn = Vue.extend({
...
@@ -61,7 +61,7 @@ const ResolveBtn = Vue.extend({
this
.
$nextTick
(()
=>
{
this
.
$nextTick
(()
=>
{
$
(
this
.
$refs
.
button
)
$
(
this
.
$refs
.
button
)
.
tooltip
(
'
hide
'
)
.
tooltip
(
'
hide
'
)
.
tooltip
(
'
fixTitle
'
);
.
tooltip
(
'
_
fixTitle
'
);
});
});
},
},
resolve
:
function
()
{
resolve
:
function
()
{
...
...
app/assets/javascripts/labels_select.js
View file @
1536c69f
...
@@ -121,7 +121,7 @@ export default class LabelsSelect {
...
@@ -121,7 +121,7 @@ export default class LabelsSelect {
$sidebarLabelTooltip
$sidebarLabelTooltip
.
attr
(
'
title
'
,
labelTooltipTitle
)
.
attr
(
'
title
'
,
labelTooltipTitle
)
.
tooltip
(
'
fixTitle
'
);
.
tooltip
(
'
_
fixTitle
'
);
$
(
'
.has-tooltip
'
,
$value
).
tooltip
({
$
(
'
.has-tooltip
'
,
$value
).
tooltip
({
container
:
'
body
'
container
:
'
body
'
...
...
app/assets/javascripts/lib/utils/common_utils.js
View file @
1536c69f
...
@@ -51,7 +51,7 @@ export const rstrip = (val) => {
...
@@ -51,7 +51,7 @@ export const rstrip = (val) => {
return
val
;
return
val
;
};
};
export
const
updateTooltipTitle
=
(
$tooltipEl
,
newTitle
)
=>
$tooltipEl
.
attr
(
'
title
'
,
newTitle
).
tooltip
(
'
fixTitle
'
);
export
const
updateTooltipTitle
=
(
$tooltipEl
,
newTitle
)
=>
$tooltipEl
.
attr
(
'
title
'
,
newTitle
).
tooltip
(
'
_
fixTitle
'
);
export
const
disableButtonIfEmptyField
=
(
fieldSelector
,
buttonSelector
,
eventName
=
'
input
'
)
=>
{
export
const
disableButtonIfEmptyField
=
(
fieldSelector
,
buttonSelector
,
eventName
=
'
input
'
)
=>
{
const
field
=
$
(
fieldSelector
);
const
field
=
$
(
fieldSelector
);
...
...
app/assets/javascripts/project_label_subscription.js
View file @
1536c69f
...
@@ -42,7 +42,7 @@ export default class ProjectLabelSubscription {
...
@@ -42,7 +42,7 @@ export default class ProjectLabelSubscription {
const
$button
=
$
(
button
);
const
$button
=
$
(
button
);
if
(
$button
.
attr
(
'
data-original-title
'
))
{
if
(
$button
.
attr
(
'
data-original-title
'
))
{
$button
.
tooltip
(
'
hide
'
).
attr
(
'
data-original-title
'
,
newAction
).
tooltip
(
'
fixTitle
'
);
$button
.
tooltip
(
'
hide
'
).
attr
(
'
data-original-title
'
,
newAction
).
tooltip
(
'
_
fixTitle
'
);
}
}
return
button
;
return
button
;
...
...
app/assets/javascripts/right_sidebar.js
View file @
1536c69f
...
@@ -102,7 +102,7 @@ Sidebar.prototype.todoUpdateDone = function(data) {
...
@@ -102,7 +102,7 @@ Sidebar.prototype.todoUpdateDone = function(data) {
.
attr
(
'
title
'
,
$el
.
data
(
`
${
attrPrefix
}
Text`
));
.
attr
(
'
title
'
,
$el
.
data
(
`
${
attrPrefix
}
Text`
));
if
(
$el
.
hasClass
(
'
has-tooltip
'
))
{
if
(
$el
.
hasClass
(
'
has-tooltip
'
))
{
$el
.
tooltip
(
'
fixTitle
'
);
$el
.
tooltip
(
'
_
fixTitle
'
);
}
}
if
(
$el
.
data
(
`
${
attrPrefix
}
Icon`
))
{
if
(
$el
.
data
(
`
${
attrPrefix
}
Icon`
))
{
...
...
app/assets/javascripts/users_select.js
View file @
1536c69f
...
@@ -199,7 +199,7 @@ function UsersSelect(currentUser, els, options = {}) {
...
@@ -199,7 +199,7 @@ function UsersSelect(currentUser, els, options = {}) {
};
};
}
}
$value
.
html
(
assigneeTemplate
(
user
));
$value
.
html
(
assigneeTemplate
(
user
));
$collapsedSidebar
.
attr
(
'
title
'
,
_
.
escape
(
user
.
name
)).
tooltip
(
'
fixTitle
'
);
$collapsedSidebar
.
attr
(
'
title
'
,
_
.
escape
(
user
.
name
)).
tooltip
(
'
_
fixTitle
'
);
return
$collapsedSidebar
.
html
(
collapsedAssigneeTemplate
(
user
));
return
$collapsedSidebar
.
html
(
collapsedAssigneeTemplate
(
user
));
});
});
};
};
...
...
app/assets/javascripts/vue_shared/directives/tooltip.js
View file @
1536c69f
...
@@ -6,7 +6,7 @@ export default {
...
@@ -6,7 +6,7 @@ export default {
},
},
componentUpdated
(
el
)
{
componentUpdated
(
el
)
{
$
(
el
).
tooltip
(
'
fixTitle
'
);
$
(
el
).
tooltip
(
'
_
fixTitle
'
);
},
},
unbind
(
el
)
{
unbind
(
el
)
{
...
...
doc/development/fe_guide/style_guide_js.md
View file @
1536c69f
...
@@ -628,7 +628,7 @@ Useful links:
...
@@ -628,7 +628,7 @@ Useful links:
// good
// good
<
span
title
=
"
tooltip text
"
>
Foo
<
/span
>
<
span
title
=
"
tooltip text
"
>
Foo
<
/span
>
$
(
'
span
'
).
tooltip
(
'
fixTitle
'
);
$
(
'
span
'
).
tooltip
(
'
_
fixTitle
'
);
```
```
### The Javascript/Vue Accord
### The Javascript/Vue Accord
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment