Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
291bd873
Commit
291bd873
authored
Mar 17, 2017
by
Gabriel Mazetto
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
One more change to the branch names to preserve metadata
parent
59588eba
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
9 deletions
+9
-9
lib/gitlab/github_import/pull_request_formatter.rb
lib/gitlab/github_import/pull_request_formatter.rb
+2
-2
spec/lib/gitlab/github_import/pull_request_formatter_spec.rb
spec/lib/gitlab/github_import/pull_request_formatter_spec.rb
+7
-7
No files found.
lib/gitlab/github_import/pull_request_formatter.rb
View file @
291bd873
...
@@ -47,7 +47,7 @@ module Gitlab
...
@@ -47,7 +47,7 @@ module Gitlab
end
end
def
source_branch_name_prefixed
def
source_branch_name_prefixed
"gh-
#{
target_branch_short_sha
}
/
#{
number
}
"
"gh-
#{
target_branch_short_sha
}
/
#{
number
}
/
#{
source_branch_user
}
/
#{
source_branch_ref
}
"
end
end
def
source_branch_exists?
def
source_branch_exists?
...
@@ -67,7 +67,7 @@ module Gitlab
...
@@ -67,7 +67,7 @@ module Gitlab
end
end
def
target_branch_name_prefixed
def
target_branch_name_prefixed
"gl-
#{
target_branch_short_sha
}
/
#{
number
}
"
"gl-
#{
target_branch_short_sha
}
/
#{
number
}
/
#{
target_branch_user
}
/
#{
target_branch_ref
}
"
end
end
def
cross_project?
def
cross_project?
...
...
spec/lib/gitlab/github_import/pull_request_formatter_spec.rb
View file @
291bd873
...
@@ -12,9 +12,9 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
...
@@ -12,9 +12,9 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
let
(
:source_branch
)
{
double
(
ref:
'branch-merged'
,
repo:
source_repo
,
sha:
source_sha
)
}
let
(
:source_branch
)
{
double
(
ref:
'branch-merged'
,
repo:
source_repo
,
sha:
source_sha
)
}
let
(
:forked_source_repo
)
{
double
(
id:
2
,
fork:
true
,
name:
'otherproject'
,
full_name:
'company/otherproject'
)
}
let
(
:forked_source_repo
)
{
double
(
id:
2
,
fork:
true
,
name:
'otherproject'
,
full_name:
'company/otherproject'
)
}
let
(
:target_repo
)
{
repository
}
let
(
:target_repo
)
{
repository
}
let
(
:target_branch
)
{
double
(
ref:
'master'
,
repo:
target_repo
,
sha:
target_sha
)
}
let
(
:target_branch
)
{
double
(
ref:
'master'
,
repo:
target_repo
,
sha:
target_sha
,
user:
octocat
)
}
let
(
:removed_branch
)
{
double
(
ref:
'removed-branch'
,
repo:
source_repo
,
sha:
'2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
)
}
let
(
:removed_branch
)
{
double
(
ref:
'removed-branch'
,
repo:
source_repo
,
sha:
'2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
,
user:
octocat
)
}
let
(
:forked_branch
)
{
double
(
ref:
'master'
,
repo:
forked_source_repo
,
sha:
'2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
)
}
let
(
:forked_branch
)
{
double
(
ref:
'master'
,
repo:
forked_source_repo
,
sha:
'2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
,
user:
octocat
)
}
let
(
:branch_deleted_repo
)
{
double
(
ref:
'master'
,
repo:
nil
,
sha:
'2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
,
user:
octocat
)
}
let
(
:branch_deleted_repo
)
{
double
(
ref:
'master'
,
repo:
nil
,
sha:
'2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
,
user:
octocat
)
}
let
(
:octocat
)
{
double
(
id:
123456
,
login:
'octocat'
,
email:
'octocat@example.com'
)
}
let
(
:octocat
)
{
double
(
id:
123456
,
login:
'octocat'
,
email:
'octocat@example.com'
)
}
let
(
:created_at
)
{
DateTime
.
strptime
(
'2011-01-26T19:01:12Z'
)
}
let
(
:created_at
)
{
DateTime
.
strptime
(
'2011-01-26T19:01:12Z'
)
}
...
@@ -207,7 +207,7 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
...
@@ -207,7 +207,7 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
let
(
:raw_data
)
{
double
(
base_data
.
merge
(
head:
removed_branch
))
}
let
(
:raw_data
)
{
double
(
base_data
.
merge
(
head:
removed_branch
))
}
it
'prefixes branch name with to avoid collision'
do
it
'prefixes branch name with to avoid collision'
do
expect
(
pull_request
.
source_branch_name
).
to
eq
"gh-
#{
target_short_sha
}
/1347"
expect
(
pull_request
.
source_branch_name
).
to
eq
"gh-
#{
target_short_sha
}
/1347
/octocat/removed-branch
"
end
end
end
end
...
@@ -215,7 +215,7 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
...
@@ -215,7 +215,7 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
let
(
:raw_data
)
{
double
(
base_data
.
merge
(
head:
forked_branch
))
}
let
(
:raw_data
)
{
double
(
base_data
.
merge
(
head:
forked_branch
))
}
it
'prefixes branch name with to avoid collision'
do
it
'prefixes branch name with to avoid collision'
do
expect
(
pull_request
.
source_branch_name
).
to
eq
"gh-
#{
target_short_sha
}
/1347"
expect
(
pull_request
.
source_branch_name
).
to
eq
"gh-
#{
target_short_sha
}
/1347
/octocat/master
"
end
end
end
end
...
@@ -223,7 +223,7 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
...
@@ -223,7 +223,7 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
let
(
:raw_data
)
{
double
(
base_data
.
merge
(
head:
branch_deleted_repo
))
}
let
(
:raw_data
)
{
double
(
base_data
.
merge
(
head:
branch_deleted_repo
))
}
it
'prefixes branch name with to avoid collision'
do
it
'prefixes branch name with to avoid collision'
do
expect
(
pull_request
.
source_branch_name
).
to
eq
"gh-
#{
target_short_sha
}
/1347"
expect
(
pull_request
.
source_branch_name
).
to
eq
"gh-
#{
target_short_sha
}
/1347
/octocat/master
"
end
end
end
end
end
end
...
@@ -241,7 +241,7 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
...
@@ -241,7 +241,7 @@ describe Gitlab::GithubImport::PullRequestFormatter, lib: true do
let
(
:raw_data
)
{
double
(
base_data
.
merge
(
base:
removed_branch
))
}
let
(
:raw_data
)
{
double
(
base_data
.
merge
(
base:
removed_branch
))
}
it
'prefixes branch name with to avoid collision'
do
it
'prefixes branch name with to avoid collision'
do
expect
(
pull_request
.
target_branch_name
).
to
eq
'gl-2e5d3239/1347'
expect
(
pull_request
.
target_branch_name
).
to
eq
'gl-2e5d3239/1347
/octocat/removed-branch
'
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment