Merge branch 'fix/13781-delete-tag-without-ajax' into 'master'

Tag deletion doesn't use AJAX anymore

See merge request !2986

CHANGELOG

@@ -7,6 +7,7 @@ v 8.5.2
   - Fix error 500 when commenting on a commit
   - Show days remaining instead of elapsed time for Milestone
   - Fix broken icons on installations with relative URL (Artem Sidorenko)
+  - Fix issue where tag list wasn't refreshed after deleting a tag
   - Fix import from gitlab.com (KazSawada)
   - Improve implementation to check read access to forks and add pagination
   - Don't show any "2FA required" message if it's not actually required

app/controllers/projects/tags_controller.rb

@@ -34,6 +34,11 @@ class Projects::TagsController < Projects::ApplicationController
   def destroy
     DeleteTagService.new(project, current_user).execute(params[:id])
 
+    respond_to do |format|
+      format.html do
         redirect_to namespace_project_tags_path(@project.namespace, @project)
       end
+      format.js
+    end
+  end
 end

app/views/projects/tags/destroy.js.haml

+$('.js-totaltags-count').html("#{@repository.tags.size}");
+- if @repository.tags.empty?
+  $('.tags').load(document.URL + ' .nothing-here-block').hide().fadeIn(1000)