Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
6597c213
Commit
6597c213
authored
Jul 12, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prefer empty relation rather than arrays
parent
a1eac5e4
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
1 deletion
+7
-1
app/models/project.rb
app/models/project.rb
+1
-1
spec/models/build_spec.rb
spec/models/build_spec.rb
+6
-0
No files found.
app/models/project.rb
View file @
6597c213
...
...
@@ -431,7 +431,7 @@ class Project < ActiveRecord::Base
def
builds_for
(
build_name
,
ref
=
'HEAD'
)
ct
=
commit
(
ref
)
return
[]
unless
ct
return
builds
.
none
unless
ct
sha
=
commit
(
ref
).
sha
...
...
spec/models/build_spec.rb
View file @
6597c213
...
...
@@ -697,5 +697,11 @@ describe Ci::Build, models: true do
expect
(
build_ids
).
to
eq
([
build
.
id
])
end
it
'returns empty relation if the build cannot be found'
do
builds
=
project
.
builds_for
(
build
.
name
,
'TAIL'
).
all
expect
(
builds
).
to
be_empty
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment