Commit 817e0bd7 authored by Mickaël Schoentgen's avatar Mickaël Schoentgen Committed by Inada Naoki

bpo-35416: fix potential resource warnings in distutils (GH-10918)

parent 868d8498
...@@ -537,7 +537,8 @@ class bdist_rpm(Command): ...@@ -537,7 +537,8 @@ class bdist_rpm(Command):
'', '',
'%' + rpm_opt,]) '%' + rpm_opt,])
if val: if val:
spec_file.extend(open(val, 'r').read().split('\n')) with open(val) as f:
spec_file.extend(f.read().split('\n'))
else: else:
spec_file.append(default) spec_file.append(default)
......
...@@ -247,12 +247,13 @@ class bdist_wininst(Command): ...@@ -247,12 +247,13 @@ class bdist_wininst(Command):
self.announce("creating %s" % installer_name) self.announce("creating %s" % installer_name)
if bitmap: if bitmap:
bitmapdata = open(bitmap, "rb").read() with open(bitmap, "rb") as f:
bitmapdata = f.read()
bitmaplen = len(bitmapdata) bitmaplen = len(bitmapdata)
else: else:
bitmaplen = 0 bitmaplen = 0
file = open(installer_name, "wb") with open(installer_name, "wb") as file:
file.write(self.get_exe_bytes()) file.write(self.get_exe_bytes())
if bitmap: if bitmap:
file.write(bitmapdata) file.write(bitmapdata)
...@@ -287,7 +288,8 @@ class bdist_wininst(Command): ...@@ -287,7 +288,8 @@ class bdist_wininst(Command):
bitmaplen, # number of bytes in bitmap bitmaplen, # number of bytes in bitmap
) )
file.write(header) file.write(header)
file.write(open(arcname, "rb").read()) with open(arcname, "rb") as f:
file.write(f.read())
def get_installer_filename(self, fullname): def get_installer_filename(self, fullname):
# Factored out to allow overriding in subclasses # Factored out to allow overriding in subclasses
......
...@@ -125,8 +125,9 @@ class upload(PyPIRCCommand): ...@@ -125,8 +125,9 @@ class upload(PyPIRCCommand):
data['comment'] = '' data['comment'] = ''
if self.sign: if self.sign:
with open(filename + ".asc", "rb") as f:
data['gpg_signature'] = (os.path.basename(filename) + ".asc", data['gpg_signature'] = (os.path.basename(filename) + ".asc",
open(filename+".asc", "rb").read()) f.read())
# set up the authentication # set up the authentication
user_pass = (self.username + ":" + self.password).encode('ascii') user_pass = (self.username + ":" + self.password).encode('ascii')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment