[renderjs_ui] Form field shows errors even when hidden (user-friendly)

bt5/erp5_web_renderjs_ui/PathTemplateItem/web_page_module/rjs_gadget_erp5_label_field_js.js

@@ -84,6 +84,8 @@
       });
     })
 
+    .declareAcquiredMethod("notifyChange", "notifyChange")
+
     .declareMethod('render', function (options) {
       var state_dict = {
         label_text: options.field_json.title || '',
@@ -105,7 +107,8 @@
 
     .onStateChange(function (modification_dict) {
       var gadget = this,
-        span;
+        span,
+        promise_queue = new RSVP.Queue();
 
       if (gadget.state.hidden) {
         this.element.hidden = true;
@@ -123,6 +126,14 @@
       }
 
       if (modification_dict.hasOwnProperty('error_text')) {
+        if (this.state.hidden) {
+          promise_queue.push(function () {
+            return gadget.notifyChange({
+              "message": gadget.state.error_text,
+              "status": "error"
+            });
+          });
+        } else {
           // first remove old errors
           span = this.state.container_element.querySelector('span');
           if (span) {
@@ -135,6 +146,7 @@
             this.state.container_element.appendChild(span);
           }
         }
+      }
 
       // Remove/add label_element from DOM
       if (modification_dict.hasOwnProperty('label')) {
@@ -147,7 +159,7 @@
 
       if (modification_dict.hasOwnProperty('options')) {
         if (this.state.field_url) {
-          return new RSVP.Queue()
+          return promise_queue
             .push(function () {
               if (modification_dict.hasOwnProperty('field_url')) {
                 return gadget.declareGadget(gadget.state.field_url, {
@@ -177,6 +189,7 @@
           if (gadget.checkValidity !== undefined) {
             return gadget.checkValidity();
           }
+          window.console.log('Gadget ' + gadget.state.field_url + ' does NOT implement checkValidity!');
           return true;
         });
     })

bt5/erp5_web_renderjs_ui/PathTemplateItem/web_page_module/rjs_gadget_erp5_label_field_js.xml

@@ -230,7 +230,7 @@
             </item>
             <item>
                 <key> <string>serial</string> </key>
-                <value> <string>961.46539.43459.6519</string> </value>
+                <value> <string>962.34466.32248.6604</string> </value>
             </item>
             <item>
                 <key> <string>state</string> </key>
@@ -248,7 +248,7 @@
                     </tuple>
                     <state>
                       <tuple>
-                        <float>1503932157.58</float>
+                        <float>1507042725.04</float>
                         <string>UTC</string>
                       </tuple>
                     </state>

bt5/erp5_web_renderjs_ui/PathTemplateItem/web_page_module/rjs_gadget_html5_element_js.js

@@ -69,6 +69,11 @@
       }
       data[this.state.name] = this.state.text_content || this.state.inner_html || "";
       return data;
+    })
+
+    /** Readonly fields are always valid */
+    .declareMethod("checkValidity", function () {
+      return true;
     });
 
 }(window, document, rJS));
\ No newline at end of file

bt5/erp5_web_renderjs_ui/PathTemplateItem/web_page_module/rjs_gadget_html5_element_js.xml

@@ -230,7 +230,7 @@
             </item>
             <item>
                 <key> <string>serial</string> </key>
-                <value> <string>961.46335.40182.23005</string> </value>
+                <value> <string>961.57904.26336.47172</string> </value>
             </item>
             <item>
                 <key> <string>state</string> </key>
@@ -248,7 +248,7 @@
                     </tuple>
                     <state>
                       <tuple>
-                        <float>1503909097.14</float>
+                        <float>1504605935.05</float>
                         <string>UTC</string>
                       </tuple>
                     </state>