Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kazuhiko Shiozaki
gitlab-ce
Commits
5e2f25c3
Commit
5e2f25c3
authored
Apr 14, 2015
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add explanation to HelpController#clean_path_info.
parent
988b7035
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
16 additions
and
3 deletions
+16
-3
app/controllers/help_controller.rb
app/controllers/help_controller.rb
+16
-3
No files found.
app/controllers/help_controller.rb
View file @
5e2f25c3
...
@@ -37,21 +37,34 @@ class HelpController < ApplicationController
...
@@ -37,21 +37,34 @@ class HelpController < ApplicationController
def
ui
def
ui
end
end
# Taken from ActionDispatch::FileHandler
PATH_SEPS
=
Regexp
.
union
(
*
[
::
File
::
SEPARATOR
,
::
File
::
ALT_SEPARATOR
].
compact
)
PATH_SEPS
=
Regexp
.
union
(
*
[
::
File
::
SEPARATOR
,
::
File
::
ALT_SEPARATOR
].
compact
)
# Taken from ActionDispatch::FileHandler
# Cleans up the path, to prevent directory traversal outside the doc folder.
def
clean_path_info
(
path_info
)
def
clean_path_info
(
path_info
)
parts
=
path_info
.
split
PATH_SEPS
parts
=
path_info
.
split
(
PATH_SEPS
)
clean
=
[]
clean
=
[]
# Walk over each part of the path
parts
.
each
do
|
part
|
parts
.
each
do
|
part
|
# Turn `one//two` or `one/./two` into `one/two`.
next
if
part
.
empty?
||
part
==
'.'
next
if
part
.
empty?
||
part
==
'.'
part
==
'..'
?
clean
.
pop
:
clean
<<
part
if
part
==
'..'
# Turn `one/two/../` into `one`
clean
.
pop
else
# Add simple folder names to the clean path.
clean
<<
part
end
end
end
# If the path was an absolute path (i.e. `/` or `/one/two`),
# add `/` to the front of the clean path.
clean
.
unshift
'/'
if
parts
.
empty?
||
parts
.
first
.
empty?
clean
.
unshift
'/'
if
parts
.
empty?
||
parts
.
first
.
empty?
# Join all the clean path parts by the path separator.
::
File
.
join
(
*
clean
)
::
File
.
join
(
*
clean
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment