More feedback fixes.

archive.go

@@ -119,8 +119,6 @@ func handleGetArchive(w http.ResponseWriter, r *gitRequest) {
 		logContext("handleGetArchive finalize cached archive", err)
 		return
 	}
-
-	return
 }
 
 func setArchiveHeaders(w http.ResponseWriter, format string, archiveFilename string) {

git-http.go

@@ -55,8 +55,6 @@ func handleGetInfoRefs(w http.ResponseWriter, r *gitRequest) {
 		logContext("handleGetInfoRefs wait for subprocess", err)
 		return
 	}
-
-	return
 }
 
 func handlePostRPC(w http.ResponseWriter, r *gitRequest) {
@@ -132,8 +130,6 @@ func handlePostRPC(w http.ResponseWriter, r *gitRequest) {
 		logContext("handlePostRPC wait for subprocess", err)
 		return
 	}
-
-	return
 }
 
 func subCommand(rpc string) string {

lfs.go

@@ -38,13 +38,10 @@ func lfsAuthorizeHandler(handleFunc serviceHandleFunc) serviceHandleFunc {
 			return
 		}
 
-		tmpDir := r.StoreLFSPath
-		if _, err := os.Stat(tmpDir); os.IsNotExist(err) {
-			if err := os.Mkdir(tmpDir, 0700); err != nil {
+		if err := os.Mkdir(r.StoreLFSPath, 0700); err != nil {
 			fail500(w, "Couldn't create directory for storing LFS tmp objects.", err)
 			return
 		}
-		}
 
 		handleFunc(w, r)
 	}, "/authorize")
@@ -56,13 +53,12 @@ func handleStoreLfsObject(w http.ResponseWriter, r *gitRequest) {
 	body = r.Body
 	defer body.Close()
 
-	tmpPath := r.StoreLFSPath
-	file, err := ioutil.TempFile(tmpPath, r.LfsOid)
+	file, err := ioutil.TempFile(r.StoreLFSPath, r.LfsOid)
 	if err != nil {
 		fail500(w, "Couldn't open tmp file for writing.", err)
 		return
 	}
-	defer os.Remove(tmpPath)
+	defer os.Remove(file.Name())
 	defer file.Close()
 
 	hash := sha256.New()