Commit 006b61ee authored by Facundo Batista's avatar Facundo Batista

Now using unittest for the tests infraestructure. Also split the

tests in those who need the network, and that who doesn't.
parent b027977e
...@@ -50,8 +50,9 @@ certificate chain file for the SSL connection. ...@@ -50,8 +50,9 @@ certificate chain file for the SSL connection.
One exception is defined as an attribute of the \module{poplib} module: One exception is defined as an attribute of the \module{poplib} module:
\begin{excdesc}{error_proto} \begin{excdesc}{error_proto}
Exception raised on any errors. The reason for the exception is Exception raised on any errors from this module (errors from
passed to the constructor as a string. \module{socket} module are not caught). The reason for the exception
is passed to the constructor as a string.
\end{excdesc} \end{excdesc}
\begin{seealso} \begin{seealso}
......
# Test just the SSL support in the socket module, in a moderately bogus way. # Test just the SSL support in the socket module, in a moderately bogus way.
import sys import sys
import unittest
from test import test_support from test import test_support
import socket import socket
import errno import errno
import threading
import subprocess
import time
# Optionally test SSL support. This requires the 'network' resource as given # Optionally test SSL support, if we have it in the tested platform
# on the regrtest command line. skip_expected = not hasattr(socket, "ssl")
skip_expected = not (test_support.is_resource_enabled('network') and
hasattr(socket, "ssl"))
def test_basic(): class ConnectedTests(unittest.TestCase):
test_support.requires('network')
def testBasic(self):
import urllib import urllib
if test_support.verbose: if test_support.verbose:
...@@ -32,24 +34,22 @@ def test_basic(): ...@@ -32,24 +34,22 @@ def test_basic():
buf = f.read() buf = f.read()
f.close() f.close()
def test_timeout(): def testTimeout(self):
test_support.requires('network')
def error_msg(extra_msg): def error_msg(extra_msg):
print >> sys.stderr, """\ print >> sys.stderr, """\
WARNING: an attempt to connect to %r %s, in WARNING: an attempt to connect to %r %s, in
test_timeout. That may be legitimate, but is not the outcome we hoped test_timeout. That may be legitimate, but is not the outcome we
for. If this message is seen often, test_timeout should be changed to hoped for. If this message is seen often, test_timeout should be
use a more reliable address.""" % (ADDR, extra_msg) changed to use a more reliable address.""" % (ADDR, extra_msg)
if test_support.verbose: if test_support.verbose:
print "test_timeout ..." print "test_timeout ..."
# A service which issues a welcome banner (without need to write # A service which issues a welcome banner (without need to write
# anything). # anything).
# XXX ("gmail.org", 995) has been unreliable so far, from time to time # XXX ("gmail.org", 995) has been unreliable so far, from time to
# XXX non-responsive for hours on end (& across all buildbot slaves, # XXX time non-responsive for hours on end (& across all buildbot
# XXX so that's not just a local thing). # XXX slaves, so that's not just a local thing).
ADDR = "gmail.org", 995 ADDR = "gmail.org", 995
s = socket.socket() s = socket.socket()
...@@ -72,25 +72,22 @@ def test_timeout(): ...@@ -72,25 +72,22 @@ def test_timeout():
ss.read(1) ss.read(1)
s.close() s.close()
def test_rude_shutdown(): class BasicTests(unittest.TestCase):
def testRudeShutdown(self):
if test_support.verbose: if test_support.verbose:
print "test_rude_shutdown ..." print "test_rude_shutdown ..."
try:
import threading
except ImportError:
return
# Some random port to connect to. # Some random port to connect to.
PORT = [9934] PORT = [9934]
listener_ready = threading.Event() listener_ready = threading.Event()
listener_gone = threading.Event() listener_gone = threading.Event()
# `listener` runs in a thread. It opens a socket listening on PORT, and # `listener` runs in a thread. It opens a socket listening on
# sits in an accept() until the main thread connects. Then it rudely # PORT, and sits in an accept() until the main thread connects.
# closes the socket, and sets Event `listener_gone` to let the main thread # Then it rudely closes the socket, and sets Event `listener_gone`
# know the socket is gone. # to let the main thread know the socket is gone.
def listener(): def listener():
s = socket.socket() s = socket.socket()
PORT[0] = test_support.bind_port(s, '', PORT[0]) PORT[0] = test_support.bind_port(s, '', PORT[0])
...@@ -118,12 +115,19 @@ def test_rude_shutdown(): ...@@ -118,12 +115,19 @@ def test_rude_shutdown():
connector() connector()
t.join() t.join()
def test_main(): def test_main():
if not hasattr(socket, "ssl"): if not hasattr(socket, "ssl"):
raise test_support.TestSkipped("socket module has no ssl support") raise test_support.TestSkipped("socket module has no ssl support")
test_rude_shutdown()
test_basic() tests = [BasicTests]
test_timeout()
if test_support.is_resource_enabled('network'):
tests.append(ConnectedTests)
thread_info = test_support.threading_setup()
test_support.run_unittest(*tests)
test_support.threading_cleanup(*thread_info)
if __name__ == "__main__": if __name__ == "__main__":
test_main() test_main()
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment