Commit 01a807db authored by Raymond Hettinger's avatar Raymond Hettinger

Array module's buffer interface can now handle empty arrays.

parent e6e660bd
...@@ -601,6 +601,13 @@ class ReTests(unittest.TestCase): ...@@ -601,6 +601,13 @@ class ReTests(unittest.TestCase):
self.assertEqual(iter.next().span(), (4, 4)) self.assertEqual(iter.next().span(), (4, 4))
self.assertRaises(StopIteration, iter.next) self.assertRaises(StopIteration, iter.next)
def test_empty_array(self):
# SF buf 1647541
import array
for typecode in 'cbBuhHiIlLfd':
a = array.array(typecode)
self.assertEqual(re.compile("bla").match(a), None)
self.assertEqual(re.compile("").match(a).groups(), ())
def run_re_tests(): def run_re_tests():
from test.re_tests import benchmarks, tests, SUCCEED, FAIL, SYNTAX_ERROR from test.re_tests import benchmarks, tests, SUCCEED, FAIL, SYNTAX_ERROR
......
...@@ -1745,6 +1745,8 @@ static PyMappingMethods array_as_mapping = { ...@@ -1745,6 +1745,8 @@ static PyMappingMethods array_as_mapping = {
(objobjargproc)array_ass_subscr (objobjargproc)array_ass_subscr
}; };
static const void *emptybuf = "";
static Py_ssize_t static Py_ssize_t
array_buffer_getreadbuf(arrayobject *self, Py_ssize_t index, const void **ptr) array_buffer_getreadbuf(arrayobject *self, Py_ssize_t index, const void **ptr)
{ {
...@@ -1754,6 +1756,8 @@ array_buffer_getreadbuf(arrayobject *self, Py_ssize_t index, const void **ptr) ...@@ -1754,6 +1756,8 @@ array_buffer_getreadbuf(arrayobject *self, Py_ssize_t index, const void **ptr)
return -1; return -1;
} }
*ptr = (void *)self->ob_item; *ptr = (void *)self->ob_item;
if (*ptr == NULL)
*ptr = emptybuf;
return self->ob_size*self->ob_descr->itemsize; return self->ob_size*self->ob_descr->itemsize;
} }
...@@ -1766,6 +1770,8 @@ array_buffer_getwritebuf(arrayobject *self, Py_ssize_t index, const void **ptr) ...@@ -1766,6 +1770,8 @@ array_buffer_getwritebuf(arrayobject *self, Py_ssize_t index, const void **ptr)
return -1; return -1;
} }
*ptr = (void *)self->ob_item; *ptr = (void *)self->ob_item;
if (*ptr == NULL)
*ptr = emptybuf;
return self->ob_size*self->ob_descr->itemsize; return self->ob_size*self->ob_descr->itemsize;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment