Commit 174e9098 authored by Mark Dickinson's avatar Mark Dickinson

Issue #532631: Add paranoid check to avoid potential buffer overflow

on systems with sizeof(int) > 4.
parent 2e648ecc
...@@ -4344,6 +4344,15 @@ formatfloat(char *buf, size_t buflen, int flags, ...@@ -4344,6 +4344,15 @@ formatfloat(char *buf, size_t buflen, int flags,
} }
if (prec < 0) if (prec < 0)
prec = 6; prec = 6;
/* make sure that the decimal representation of precision really does
need at most 10 digits: platforms with sizeof(int) == 8 exist! */
if (prec > 0x7fffffffL) {
PyErr_SetString(PyExc_OverflowError,
"outrageously large precision "
"for formatted float");
return -1;
}
if (type == 'f' && fabs(x) >= 1e50) if (type == 'f' && fabs(x) >= 1e50)
type = 'g'; type = 'g';
/* Worst case length calc to ensure no buffer overrun: /* Worst case length calc to ensure no buffer overrun:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment