Commit 1ae529a0 authored by Neal Norwitz's avatar Neal Norwitz

Try to fix breakage caused by patch #1479181, r45850

parent b6743626
...@@ -872,7 +872,7 @@ class Popen(object): ...@@ -872,7 +872,7 @@ class Popen(object):
# object do the translation: It is based on stdio, which is # object do the translation: It is based on stdio, which is
# impossible to combine with select (unless forcing no # impossible to combine with select (unless forcing no
# buffering). # buffering).
if self.universal_newlines and hasattr(open, 'newlines'): if self.universal_newlines and hasattr(file, 'newlines'):
if stdout: if stdout:
stdout = self._translate_newlines(stdout) stdout = self._translate_newlines(stdout)
if stderr: if stderr:
...@@ -1141,7 +1141,7 @@ class Popen(object): ...@@ -1141,7 +1141,7 @@ class Popen(object):
# object do the translation: It is based on stdio, which is # object do the translation: It is based on stdio, which is
# impossible to combine with select (unless forcing no # impossible to combine with select (unless forcing no
# buffering). # buffering).
if self.universal_newlines and hasattr(open, 'newlines'): if self.universal_newlines and hasattr(file, 'newlines'):
if stdout: if stdout:
stdout = self._translate_newlines(stdout) stdout = self._translate_newlines(stdout)
if stderr: if stderr:
......
...@@ -347,7 +347,7 @@ class ProcessTestCase(unittest.TestCase): ...@@ -347,7 +347,7 @@ class ProcessTestCase(unittest.TestCase):
stdout=subprocess.PIPE, stdout=subprocess.PIPE,
universal_newlines=1) universal_newlines=1)
stdout = p.stdout.read() stdout = p.stdout.read()
if hasattr(p.stdout, 'newlines'): if hasattr(file, 'newlines'):
# Interpreter with universal newline support # Interpreter with universal newline support
self.assertEqual(stdout, self.assertEqual(stdout,
"line1\nline2\nline3\nline4\nline5\nline6") "line1\nline2\nline3\nline4\nline5\nline6")
...@@ -374,7 +374,7 @@ class ProcessTestCase(unittest.TestCase): ...@@ -374,7 +374,7 @@ class ProcessTestCase(unittest.TestCase):
stdout=subprocess.PIPE, stderr=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
universal_newlines=1) universal_newlines=1)
(stdout, stderr) = p.communicate() (stdout, stderr) = p.communicate()
if hasattr(stdout, 'newlines'): if hasattr(file, 'newlines'):
# Interpreter with universal newline support # Interpreter with universal newline support
self.assertEqual(stdout, self.assertEqual(stdout,
"line1\nline2\nline3\nline4\nline5\nline6") "line1\nline2\nline3\nline4\nline5\nline6")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment