Issue #18347: ElementTree's html serializer now preserves the case of closing tags.

20d46692 · Christian Heimes · 0c503c2c · 20d46692 · 20d46692 · 20d46692
Commit 20d46692 authored Jul 05, 2013 by Christian Heimes
Show whitespace changes
Inline Side-by-side

Showing with 16 additions and 3 deletions

Lib/test/test_xml_etree.py Lib/test/test_xml_etree.py +10 -0

Lib/xml/etree/ElementTree.py Lib/xml/etree/ElementTree.py +3 -3

Misc/NEWS Misc/NEWS +3 -0

No files found.
--- a/Lib/test/test_xml_etree.py
+++ b/Lib/test/test_xml_etree.py
@@ -1769,6 +1769,16 @@ def bug_200709_iter_comment():

    """

+def bug_18347():
+    """
+
+    >>> e = ET.XML('<html><CamelCase>text</CamelCase></html>')
+    >>> serialize(e)
+    '<html><CamelCase>text</CamelCase></html>'
+    >>> serialize(e, method="html")
+    '<html><CamelCase>text</CamelCase></html>'
+    """
+
 # --------------------------------------------------------------------
 # reported on bugs.python.org


--- a/Lib/xml/etree/ElementTree.py
+++ b/Lib/xml/etree/ElementTree.py
@@ -988,15 +988,15 @@ def _serialize_html(write, elem, encoding, qnames, namespaces):
                    # FIXME: handle boolean attributes
                    write(" %s=\"%s\"" % (qnames[k], v))
            write(">")
-            tag = tag.lower()
+            ltag = tag.lower()
            if text:
-                if tag == "script" or tag == "style":
+                if ltag == "script" or ltag == "style":
                    write(_encode(text, encoding))
                else:
                    write(_escape_cdata(text, encoding))
            for e in elem:
                _serialize_html(write, e, encoding, qnames, None)
-            if tag not in HTML_EMPTY:
+            if ltag not in HTML_EMPTY:
                write("</" + tag + ">")
    if elem.tail:
        write(_escape_cdata(elem.tail, encoding))

--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -24,6 +24,9 @@ Core and Builtins
 Library
 -------

+- Issue #18347: ElementTree's html serializer now preserves the case of
+  closing tags.
+
 - Issue #17261: Ensure multiprocessing's proxies use proper address.

 - Issue #17097: Make multiprocessing ignore EINTR.