Commit 2bcde144 authored by Raymond Hettinger's avatar Raymond Hettinger

Issue 5982: Classmethod and staticmethod expose wrapped function with __func__.

parent ebe99ab3
...@@ -254,11 +254,23 @@ class CellTest(unittest.TestCase): ...@@ -254,11 +254,23 @@ class CellTest(unittest.TestCase):
self.assert_(cell(-36) == cell(-36.0)) self.assert_(cell(-36) == cell(-36.0))
self.assert_(cell(True) > empty_cell()) self.assert_(cell(True) > empty_cell())
class StaticMethodAttrsTest(unittest.TestCase):
def test_func_attribute(self):
def f():
pass
c = classmethod(f)
self.assert_(c.__func__ is f)
s = staticmethod(f)
self.assert_(s.__func__ is f)
def test_main(): def test_main():
support.run_unittest(FunctionPropertiesTest, ImplicitReferencesTest, support.run_unittest(FunctionPropertiesTest, ImplicitReferencesTest,
ArbitraryFunctionAttrTest, FunctionDictsTest, ArbitraryFunctionAttrTest, FunctionDictsTest,
FunctionDocstringTest, CellTest) FunctionDocstringTest, CellTest,
StaticMethodAttrsTest)
if __name__ == "__main__": if __name__ == "__main__":
test_main() test_main()
...@@ -15,6 +15,9 @@ Core and Builtins ...@@ -15,6 +15,9 @@ Core and Builtins
- Issue #6089: Fixed str.format with certain invalid field specifiers - Issue #6089: Fixed str.format with certain invalid field specifiers
that would raise SystemError. that would raise SystemError.
- Issue #5982: staticmethod and classmethod now expose the wrapped
function with __func__.
- Added support for multiple context managers in the same with-statement. - Added support for multiple context managers in the same with-statement.
Deprecated contextlib.nested() which is no longer needed. Deprecated contextlib.nested() which is no longer needed.
......
...@@ -775,6 +775,11 @@ cm_init(PyObject *self, PyObject *args, PyObject *kwds) ...@@ -775,6 +775,11 @@ cm_init(PyObject *self, PyObject *args, PyObject *kwds)
return 0; return 0;
} }
static PyMemberDef cm_memberlist[] = {
{"__func__", T_OBJECT, offsetof(classmethod, cm_callable), READONLY},
{NULL} /* Sentinel */
};
PyDoc_STRVAR(classmethod_doc, PyDoc_STRVAR(classmethod_doc,
"classmethod(function) -> method\n\ "classmethod(function) -> method\n\
\n\ \n\
...@@ -825,7 +830,7 @@ PyTypeObject PyClassMethod_Type = { ...@@ -825,7 +830,7 @@ PyTypeObject PyClassMethod_Type = {
0, /* tp_iter */ 0, /* tp_iter */
0, /* tp_iternext */ 0, /* tp_iternext */
0, /* tp_methods */ 0, /* tp_methods */
0, /* tp_members */ cm_memberlist, /* tp_members */
0, /* tp_getset */ 0, /* tp_getset */
0, /* tp_base */ 0, /* tp_base */
0, /* tp_dict */ 0, /* tp_dict */
...@@ -925,6 +930,11 @@ sm_init(PyObject *self, PyObject *args, PyObject *kwds) ...@@ -925,6 +930,11 @@ sm_init(PyObject *self, PyObject *args, PyObject *kwds)
return 0; return 0;
} }
static PyMemberDef sm_memberlist[] = {
{"__func__", T_OBJECT, offsetof(staticmethod, sm_callable), READONLY},
{NULL} /* Sentinel */
};
PyDoc_STRVAR(staticmethod_doc, PyDoc_STRVAR(staticmethod_doc,
"staticmethod(function) -> method\n\ "staticmethod(function) -> method\n\
\n\ \n\
...@@ -972,7 +982,7 @@ PyTypeObject PyStaticMethod_Type = { ...@@ -972,7 +982,7 @@ PyTypeObject PyStaticMethod_Type = {
0, /* tp_iter */ 0, /* tp_iter */
0, /* tp_iternext */ 0, /* tp_iternext */
0, /* tp_methods */ 0, /* tp_methods */
0, /* tp_members */ sm_memberlist, /* tp_members */
0, /* tp_getset */ 0, /* tp_getset */
0, /* tp_base */ 0, /* tp_base */
0, /* tp_dict */ 0, /* tp_dict */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment