Commit 2c316a3e authored by Raymond Hettinger's avatar Raymond Hettinger

Issue 11802: filecmp cache was growing without bound.

parent fd1cb596
...@@ -48,11 +48,12 @@ def cmp(f1, f2, shallow=1): ...@@ -48,11 +48,12 @@ def cmp(f1, f2, shallow=1):
if s1[1] != s2[1]: if s1[1] != s2[1]:
return False return False
result = _cache.get((f1, f2)) outcome = _cache.get((f1, f2, s1, s2))
if result and (s1, s2) == result[:2]: if outcome is None:
return result[2]
outcome = _do_cmp(f1, f2) outcome = _do_cmp(f1, f2)
_cache[f1, f2] = s1, s2, outcome if len(_cache) > 100: # limit the maximum size of the cache
_cache.clear()
_cache[f1, f2, s1, s2] = outcome
return outcome return outcome
def _sig(st): def _sig(st):
......
...@@ -16,6 +16,9 @@ Core and Builtins ...@@ -16,6 +16,9 @@ Core and Builtins
Library Library
------- -------
- Issue #11802: The cache in filecmp now has a maximum size of 100 so that
it won't grow without bound.
- Issue #12404: Remove C89 incompatible code from mmap module. Patch by Akira - Issue #12404: Remove C89 incompatible code from mmap module. Patch by Akira
Kitada. Kitada.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment