#1389051: IMAP module tries to read entire message in one chunk. Patch by Fredrik Lundh.

37d4f7bc · Andrew M. Kuchling · 31679397 · 37d4f7bc · 37d4f7bc
Commit 37d4f7bc authored Feb 23, 2008 by Andrew M. Kuchling
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

Lib/imaplib.py Lib/imaplib.py +1 -1

Misc/NEWS Misc/NEWS +3 -0

No files found.
--- a/Lib/imaplib.py
+++ b/Lib/imaplib.py
@@ -1147,7 +1147,7 @@ class IMAP4_SSL(IMAP4):
        chunks = []
        read = 0
        while read < size:
-            data = self.sslobj.read(size-read)
+            data = self.sslobj.read(min(size-read, 16384))
            read += len(data)
            chunks.append(data)

--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -15,6 +15,9 @@ Core and builtins
 Library
 -------
+- Bug #1389051: imaplib causes excessive memory fragmentation when reading
+  large messages.
 - Bug #1433694: minidom's .normalize() failed to set .nextSibling for
  last child element.