Commit 38c741c1 authored by Vinay Sajip's avatar Vinay Sajip

Issue #19182: Fixed socket leak on exception when connecting.

parent fd115517
...@@ -518,7 +518,11 @@ class SocketHandler(logging.Handler): ...@@ -518,7 +518,11 @@ class SocketHandler(logging.Handler):
else: else:
result = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) result = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
result.settimeout(timeout) result.settimeout(timeout)
try:
result.connect(self.address) result.connect(self.address)
except OSError:
result.close() # Issue 19182
raise
return result return result
def createSocket(self): def createSocket(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment