Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
4249ccc2
Commit
4249ccc2
authored
Jan 02, 2003
by
Skip Montanaro
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow list sort's comparison function to explicitly be None. See SF patch
661092.
parent
2e42aedc
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
34 additions
and
6 deletions
+34
-6
Doc/lib/libstdtypes.tex
Doc/lib/libstdtypes.tex
+6
-5
Lib/test/test_sort.py
Lib/test/test_sort.py
+20
-0
Misc/NEWS
Misc/NEWS
+4
-0
Objects/listobject.c
Objects/listobject.c
+4
-1
No files found.
Doc/lib/libstdtypes.tex
View file @
4249ccc2
...
...
@@ -925,7 +925,7 @@ The following operations are defined on mutable sequence types (where
{
same as
\code
{
del
\var
{
s
}
[
\var
{
s
}
.index(
\var
{
x
}
)]
}}{
(3)
}
\lineiii
{
\var
{
s
}
.reverse()
}
{
reverses the items of
\var
{
s
}
in place
}{
(6)
}
\lineiii
{
\var
{
s
}
.sort(
\optional
{
\var
{
cmpfunc
}}
)
}
\lineiii
{
\var
{
s
}
.sort(
\optional
{
\var
{
cmpfunc
=None
}}
)
}
{
sort the items of
\var
{
s
}
in place
}{
(6), (7), (8), (9)
}
\end{tableiii}
\indexiv
{
operations on
}{
mutable
}{
sequence
}{
types
}
...
...
@@ -970,10 +970,11 @@ Notes:
the first argument is considered smaller than, equal to, or larger
than the second argument. Note that this slows the sorting process
down considerably; e.g. to sort a list in reverse order it is much
faster to call method
\method
{
sort()
}
followed by
\method
{
reverse()
}
than to use method
\method
{
sort()
}
with a comparison function that reverses the
ordering of the elements.
faster to call method
\method
{
sort()
}
followed by
\method
{
reverse()
}
than to use method
\method
{
sort()
}
with a comparison function that
reverses the ordering of the elements. Passing
\constant
{
None
}
as the
comparison function is semantically equivalent to calling
\method
{
sort()
}
with no comparison function.
\item
[(8)]
Whether the
\method
{
sort()
}
method is stable is not defined by
the language (a sort is stable if it guarantees not to change the
...
...
Lib/test/test_sort.py
View file @
4249ccc2
...
...
@@ -145,6 +145,26 @@ def bug453523():
bug453523
()
def
cmpNone
():
global
nerrors
if
verbose
:
print
"Testing None as a comparison function."
L
=
range
(
50
)
random
.
shuffle
(
L
)
try
:
L
.
sort
(
None
)
except
TypeError
:
print
" Passing None as cmpfunc failed."
nerrors
+=
1
else
:
if
L
!=
range
(
50
):
print
" Passing None as cmpfunc failed."
nerrors
+=
1
cmpNone
()
if
nerrors
:
print
"Test failed"
,
nerrors
elif
verbose
:
...
...
Misc/NEWS
View file @
4249ccc2
...
...
@@ -12,6 +12,10 @@ What's New in Python 2.3 alpha 2?
Core and builtins
-----------------
- List objects'
sort
()
method
now
accepts
None
as
the
comparison
function
.
Passing
None
is
semantically
identical
to
calling
sort
()
with
no
arguments
.
Extension
modules
-----------------
...
...
Objects/listobject.c
View file @
4249ccc2
...
...
@@ -1657,6 +1657,9 @@ listsort(PyListObject *self, PyObject *args)
if
(
!
PyArg_UnpackTuple
(
args
,
"sort"
,
0
,
1
,
&
compare
))
return
NULL
;
}
if
(
compare
==
Py_None
)
compare
=
NULL
;
merge_init
(
&
ms
,
compare
);
/* The list is temporarily made empty, so that mutations performed
...
...
@@ -2069,7 +2072,7 @@ PyDoc_STRVAR(count_doc,
PyDoc_STRVAR
(
reverse_doc
,
"L.reverse() -- reverse *IN PLACE*"
);
PyDoc_STRVAR
(
sort_doc
,
"L.sort(
[cmpfunc]
) -- stable sort *IN PLACE*; cmpfunc(x, y) -> -1, 0, 1"
);
"L.sort(
cmpfunc=None
) -- stable sort *IN PLACE*; cmpfunc(x, y) -> -1, 0, 1"
);
static
PyMethodDef
list_methods
[]
=
{
{
"append"
,
(
PyCFunction
)
listappend
,
METH_O
,
append_doc
},
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment