Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
44c66c72
Commit
44c66c72
authored
Dec 29, 2012
by
Serhiy Storchaka
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #16486: Make aifc files work with 'with' as context managers.
parent
ff2840a7
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
30 additions
and
0 deletions
+30
-0
Doc/library/aifc.rst
Doc/library/aifc.rst
+4
-0
Lib/aifc.py
Lib/aifc.py
+12
-0
Lib/test/test_aifc.py
Lib/test/test_aifc.py
+12
-0
Misc/NEWS
Misc/NEWS
+2
-0
No files found.
Doc/library/aifc.rst
View file @
44c66c72
...
...
@@ -51,6 +51,10 @@ Module :mod:`aifc` defines the following function:
used for writing, the file object should be seekable, unless you know ahead of
time how many samples you are going to write in total and use
:meth:`writeframesraw` and :meth:`setnframes`.
Objects returned by :func:`.open` also supports the :keyword:`with` statement.
.. versionchanged:: 3.4
Support for the :keyword:`with` statement was added.
Objects returned by :func:`.open` when a file is opened for reading have the
following methods:
...
...
Lib/aifc.py
View file @
44c66c72
...
...
@@ -334,6 +334,12 @@ class Aifc_read:
# else, assume it is an open file object already
self
.
initfp
(
f
)
def
__enter__
(
self
):
return
self
def
__exit__
(
self
,
*
args
):
self
.
close
()
#
# User visible methods.
#
...
...
@@ -553,6 +559,12 @@ class Aifc_write:
def
__del__
(
self
):
self
.
close
()
def
__enter__
(
self
):
return
self
def
__exit__
(
self
,
*
args
):
self
.
close
()
#
# User visible methods.
#
...
...
Lib/test/test_aifc.py
View file @
44c66c72
...
...
@@ -43,6 +43,18 @@ class AIFCTest(unittest.TestCase):
(
2
,
2
,
48000
,
14400
,
b'NONE'
,
b'not compressed'
),
)
def
test_context_manager
(
self
):
with
open
(
self
.
sndfilepath
,
'rb'
)
as
testfile
:
with
aifc
.
open
(
testfile
)
as
f
:
pass
self
.
assertEqual
(
testfile
.
closed
,
True
)
with
open
(
TESTFN
,
'wb'
)
as
testfile
:
with
self
.
assertRaises
(
aifc
.
Error
):
with
aifc
.
open
(
testfile
,
'wb'
)
as
fout
:
pass
self
.
assertEqual
(
testfile
.
closed
,
True
)
fout
.
close
()
# do nothing
def
test_read
(
self
):
f
=
self
.
f
=
aifc
.
open
(
self
.
sndfilepath
)
self
.
assertEqual
(
f
.
readframes
(
0
),
b''
)
...
...
Misc/NEWS
View file @
44c66c72
...
...
@@ -200,6 +200,8 @@ Core and Builtins
Library
-------
-
Issue
#
16486
:
Make
aifc
files
work
with
'with'
as
context
managers
.
-
Issue
#
16485
:
Fix
file
descriptor
not
being
closed
if
file
header
patching
fails
on
closing
of
aifc
file
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment