Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
53071262
Commit
53071262
authored
May 11, 2011
by
Victor Stinner
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #11169: compileall module uses repr() to format filenames and paths to
escape surrogate characters and show spaces.
parent
1eb4f28c
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
6 deletions
+9
-6
Lib/compileall.py
Lib/compileall.py
+5
-5
Lib/test/test_compileall.py
Lib/test/test_compileall.py
+1
-1
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/compileall.py
View file @
53071262
...
...
@@ -35,11 +35,11 @@ def compile_dir(dir, maxlevels=10, ddir=None, force=False, rx=None,
optimize: optimization level or -1 for level of the interpreter
"""
if
not
quiet
:
print
(
'Listing
'
,
dir
,
'...'
)
print
(
'Listing
{!r}...'
.
format
(
dir
)
)
try
:
names
=
os
.
listdir
(
dir
)
except
os
.
error
:
print
(
"Can't list
"
,
dir
)
print
(
"Can't list
{!r}"
.
format
(
dir
)
)
names
=
[]
names
.
sort
()
success
=
1
...
...
@@ -109,13 +109,13 @@ def compile_file(fullname, ddir=None, force=False, rx=None, quiet=False,
except
IOError
:
pass
if
not
quiet
:
print
(
'Compiling
'
,
fullname
,
'...'
)
print
(
'Compiling
{!r}...'
.
format
(
fullname
)
)
try
:
ok
=
py_compile
.
compile
(
fullname
,
cfile
,
dfile
,
True
,
optimize
=
optimize
)
except
py_compile
.
PyCompileError
as
err
:
if
quiet
:
print
(
'*** Error compiling
'
,
fullname
,
'...'
)
print
(
'*** Error compiling
{!r}...'
.
format
(
fullname
)
)
else
:
print
(
'*** '
,
end
=
''
)
# escape non-printable characters in msg
...
...
@@ -126,7 +126,7 @@ def compile_file(fullname, ddir=None, force=False, rx=None, quiet=False,
success
=
0
except
(
SyntaxError
,
UnicodeError
,
IOError
)
as
e
:
if
quiet
:
print
(
'*** Error compiling
'
,
fullname
,
'...'
)
print
(
'*** Error compiling
{!r}...'
.
format
(
fullname
)
)
else
:
print
(
'*** '
,
end
=
''
)
print
(
e
.
__class__
.
__name__
+
':'
,
e
)
...
...
Lib/test/test_compileall.py
View file @
53071262
...
...
@@ -345,7 +345,7 @@ class CommandLineTests(unittest.TestCase):
def test_invalid_arg_produces_message(self):
out = self.assertRunOK('
badfilename
')
self.assertRegex(out, b"Can'
t
list
badfilename
")
self.assertRegex(out, b"Can'
t
list
'badfilename'
")
def test_main():
...
...
Misc/NEWS
View file @
53071262
...
...
@@ -86,6 +86,9 @@ Core and Builtins
Library
-------
-
Issue
#
11169
:
compileall
module
uses
repr
()
to
format
filenames
and
paths
to
escape
surrogate
characters
and
show
spaces
.
-
Issue
#
10419
,
#
6011
:
build_scripts
command
of
distutils
handles
correctly
non
-
ASCII
path
(
path
to
the
Python
executable
).
Open
and
write
the
script
in
binary
mode
,
but
ensure
that
the
shebang
is
decodable
from
UTF
-
8
and
from
the
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment