bpo-32020: arraymodule: Correct missing Py_DECREF in failure case of make_array() (#4391)

56935a53 · Mat M · Serhiy Storchaka · 28b62482 · 56935a53
Commit 56935a53 authored Nov 14, 2017 by Mat M Committed by Serhiy Storchaka Nov 14, 2017
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

Modules/arraymodule.c Modules/arraymodule.c +3 -1

No files found.
--- a/Modules/arraymodule.c
+++ b/Modules/arraymodule.c
@@ -1928,8 +1928,10 @@ make_array(PyTypeObject *arraytype, char typecode, PyObject *items)
        return NULL;

    new_args = PyTuple_New(2);
-    if (new_args == NULL)
+    if (new_args == NULL) {
+        Py_DECREF(typecode_obj);
        return NULL;
+    }
    Py_INCREF(items);
    PyTuple_SET_ITEM(new_args, 0, typecode_obj);
    PyTuple_SET_ITEM(new_args, 1, items);