Commit 61b787e6 authored by Vinay Sajip's avatar Vinay Sajip

Closes #13661: Check added for type of logger name.

parent ebfaabd6
...@@ -1094,6 +1094,8 @@ class Manager(object): ...@@ -1094,6 +1094,8 @@ class Manager(object):
placeholder to now point to the logger. placeholder to now point to the logger.
""" """
rv = None rv = None
if not isinstance(name, str):
raise ValueError('A logger name must be a string')
_acquireLock() _acquireLock()
try: try:
if name in self.loggerDict: if name in self.loggerDict:
......
...@@ -293,6 +293,8 @@ class BuiltinLevelsTest(BaseTest): ...@@ -293,6 +293,8 @@ class BuiltinLevelsTest(BaseTest):
('INF.BADPARENT', 'INFO', '4'), ('INF.BADPARENT', 'INFO', '4'),
]) ])
def test_invalid_name(self):
self.assertRaises(ValueError, logging.getLogger, any)
class BasicFilterTest(BaseTest): class BasicFilterTest(BaseTest):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment