Commit 89446b2c authored by Mark Dickinson's avatar Mark Dickinson

Issue #25604: Fix bug in integer true division that could have resulted in...

Issue #25604: Fix bug in integer true division that could have resulted in off-by-one-ulp results in unusual cases.
parent 7ff1b62d
......@@ -10,6 +10,10 @@ What's New in Python 2.7.13?
Core and Builtins
-----------------
- Issue #25604: Fix a minor bug in integer true division; this bug could
potentially have caused off-by-one-ulp results on platforms with
unreliable ldexp implementations.
- Issue #27473: Fixed possible integer overflow in str, unicode and bytearray
concatenations and repetitions. Based on patch by Xiang Zhang.
......
......@@ -3315,9 +3315,9 @@ long_true_divide(PyObject *v, PyObject *w)
/* Round by directly modifying the low digit of x. */
mask = (digit)1 << (extra_bits - 1);
low = x->ob_digit[0] | inexact;
if (low & mask && low & (3*mask-1))
if ((low & mask) && (low & (3U*mask-1U)))
low += mask;
x->ob_digit[0] = low & ~(mask-1U);
x->ob_digit[0] = low & ~(2U*mask-1U);
/* Convert x to a double dx; the conversion is exact. */
dx = x->ob_digit[--x_size];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment