Commit 93320968 authored by Victor Stinner's avatar Victor Stinner

Issue #20311: Revert 033137c12d88, select.epoll.poll() rounds again the timeout

towards zero
parent b72e69e5
...@@ -217,17 +217,6 @@ class TestEPoll(unittest.TestCase): ...@@ -217,17 +217,6 @@ class TestEPoll(unittest.TestCase):
server.close() server.close()
ep.unregister(fd) ep.unregister(fd)
def test_timeout_rounding(self):
# epoll_wait() has a resolution of 1 millisecond, check if the timeout
# is correctly rounded to the upper bound
epoll = select.epoll()
self.addCleanup(epoll.close)
for timeout in (1e-2, 1e-3, 1e-4):
t0 = time.monotonic()
epoll.poll(timeout)
dt = time.monotonic() - t0
self.assertGreaterEqual(dt, timeout)
def test_main(): def test_main():
support.run_unittest(TestEPoll) support.run_unittest(TestEPoll)
......
...@@ -58,10 +58,6 @@ Library ...@@ -58,10 +58,6 @@ Library
- Issue #20374: Fix build with GNU readline >= 6.3. - Issue #20374: Fix build with GNU readline >= 6.3.
- Issue #20311: select.epoll.poll() now rounds the timeout away from zero,
instead of rounding towards zero. For example, a timeout of one microsecond
is now rounded to one millisecond, instead of being rounded to zero.
- Issue #20262: Warnings are raised now when duplicate names are added in the - Issue #20262: Warnings are raised now when duplicate names are added in the
ZIP file or too long ZIP file comment is truncated. ZIP file or too long ZIP file comment is truncated.
......
...@@ -1379,9 +1379,7 @@ pyepoll_poll(pyEpoll_Object *self, PyObject *args, PyObject *kwds) ...@@ -1379,9 +1379,7 @@ pyepoll_poll(pyEpoll_Object *self, PyObject *args, PyObject *kwds)
return NULL; return NULL;
} }
else { else {
/* epoll_wait() has a resolution of 1 millisecond, round away from zero timeout = (int)(dtimeout * 1000.0);
to wait *at least* dtimeout seconds. */
timeout = (int)ceil(dtimeout * 1000.0);
} }
if (maxevents == -1) { if (maxevents == -1) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment