Commit 9ffb1481 authored by Gregory P. Smith's avatar Gregory P. Smith

Fixes Issue #17200: telnetlib's read_until and expect timeout was broken by the

fix to Issue #14635 in Python 2.7.4 to be interpreted as milliseconds
instead of seconds when the platform supports select.poll (ie: everywhere).
It is now treated as seconds once again.
parent 278543d5
...@@ -312,7 +312,9 @@ class Telnet: ...@@ -312,7 +312,9 @@ class Telnet:
poller.register(self, poll_in_or_priority_flags) poller.register(self, poll_in_or_priority_flags)
while i < 0 and not self.eof: while i < 0 and not self.eof:
try: try:
ready = poller.poll(call_timeout) # Poll takes its timeout in milliseconds.
ready = poller.poll(None if timeout is None
else 1000 * call_timeout)
except select.error as e: except select.error as e:
if e.errno == errno.EINTR: if e.errno == errno.EINTR:
if timeout is not None: if timeout is not None:
...@@ -682,7 +684,8 @@ class Telnet: ...@@ -682,7 +684,8 @@ class Telnet:
poller.register(self, poll_in_or_priority_flags) poller.register(self, poll_in_or_priority_flags)
while not m and not self.eof: while not m and not self.eof:
try: try:
ready = poller.poll(call_timeout) ready = poller.poll(None if timeout is None
else 1000 * call_timeout)
except select.error as e: except select.error as e:
if e.errno == errno.EINTR: if e.errno == errno.EINTR:
if timeout is not None: if timeout is not None:
......
...@@ -17,6 +17,11 @@ Core and Builtins ...@@ -17,6 +17,11 @@ Core and Builtins
Library Library
------- -------
- Issue #17200: telnetlib's read_until and expect timeout was broken by the
fix to Issue #14635 in Python 2.7.4 to be interpreted as milliseconds
instead of seconds when the platform supports select.poll (ie: everywhere).
It is now treated as seconds once again.
- Issue #19099: The struct module now supports Unicode format strings. - Issue #19099: The struct module now supports Unicode format strings.
- Issue #19878: Fix segfault in bz2 module after calling __init__ twice with - Issue #19878: Fix segfault in bz2 module after calling __init__ twice with
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment