Commit a2133519 authored by Ned Deily's avatar Ned Deily

Issue #18071: Extension module builds on OS X could fail with TypeError

if Xcode command line tools were not installed.
parent c32e24db
...@@ -53,7 +53,7 @@ def _find_executable(executable, path=None): ...@@ -53,7 +53,7 @@ def _find_executable(executable, path=None):
def _read_output(commandstring): def _read_output(commandstring):
"""Output from succesful command execution or None""" """Output from successful command execution or None"""
# Similar to os.popen(commandstring, "r").read(), # Similar to os.popen(commandstring, "r").read(),
# but without actually using os.popen because that # but without actually using os.popen because that
# function is not usable during python bootstrap. # function is not usable during python bootstrap.
...@@ -68,7 +68,7 @@ def _read_output(commandstring): ...@@ -68,7 +68,7 @@ def _read_output(commandstring):
with contextlib.closing(fp) as fp: with contextlib.closing(fp) as fp:
cmd = "%s 2>/dev/null >'%s'" % (commandstring, fp.name) cmd = "%s 2>/dev/null >'%s'" % (commandstring, fp.name)
return fp.read().decode('utf-8').strip() if not os.system(cmd) else None return fp.read().strip() if not os.system(cmd) else None
def _find_build_tool(toolname): def _find_build_tool(toolname):
......
...@@ -74,6 +74,9 @@ Library ...@@ -74,6 +74,9 @@ Library
the default for linking if LDSHARED is not also overriden. This restores the default for linking if LDSHARED is not also overriden. This restores
Distutils behavior introduced in 2.7.3 and inadvertently dropped in 2.7.4. Distutils behavior introduced in 2.7.3 and inadvertently dropped in 2.7.4.
- Issue #18071: C extension module builds on OS X could fail with TypeError
if the Xcode command line tools were not installed.
- Issue #18113: Fixed a refcount leak in the curses.panel module's - Issue #18113: Fixed a refcount leak in the curses.panel module's
set_userptr() method. Reported by Atsuo Ishimoto. set_userptr() method. Reported by Atsuo Ishimoto.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment