Commit a33cef69 authored by Ezio Melotti's avatar Ezio Melotti

#7310: fix the repr() of os.environ

parent 3824d104
...@@ -387,22 +387,32 @@ class _Environ(MutableMapping): ...@@ -387,22 +387,32 @@ class _Environ(MutableMapping):
self.data = data = {} self.data = data = {}
for key, value in environ.items(): for key, value in environ.items():
data[keymap(key)] = str(value) data[keymap(key)] = str(value)
def __getitem__(self, key): def __getitem__(self, key):
return self.data[self.keymap(key)] return self.data[self.keymap(key)]
def __setitem__(self, key, value): def __setitem__(self, key, value):
value = str(value) value = str(value)
self.putenv(key, value) self.putenv(key, value)
self.data[self.keymap(key)] = value self.data[self.keymap(key)] = value
def __delitem__(self, key): def __delitem__(self, key):
self.unsetenv(key) self.unsetenv(key)
del self.data[self.keymap(key)] del self.data[self.keymap(key)]
def __iter__(self): def __iter__(self):
for key in self.data: for key in self.data:
yield key yield key
def __len__(self): def __len__(self):
return len(self.data) return len(self.data)
def __repr__(self):
return 'environ({!r})'.format(self.data)
def copy(self): def copy(self):
return dict(self) return dict(self)
def setdefault(self, key, value): def setdefault(self, key, value):
if key not in self: if key not in self:
self[key] = value self[key] = value
......
...@@ -400,6 +400,14 @@ class EnvironTests(mapping_tests.BasicTestMappingProtocol): ...@@ -400,6 +400,14 @@ class EnvironTests(mapping_tests.BasicTestMappingProtocol):
for key, value in self._reference().items(): for key, value in self._reference().items():
self.assertEqual(os.environ.get(key), value) self.assertEqual(os.environ.get(key), value)
# Issue 7310
def test___repr__(self):
"""Check that the repr() of os.environ looks like environ({...})."""
env = os.environ
self.assertTrue(isinstance(env.data, dict))
self.assertEqual(repr(env), 'environ({!r})'.format(env.data))
class WalkTests(unittest.TestCase): class WalkTests(unittest.TestCase):
"""Tests for os.walk().""" """Tests for os.walk()."""
......
...@@ -247,6 +247,8 @@ C-API ...@@ -247,6 +247,8 @@ C-API
Library Library
------- -------
- Issue #7310: fix the __repr__ of os.environ to show the environment variables.
- Issue #7970: email.Generator.flatten now correctly flattens message/rfc822 - Issue #7970: email.Generator.flatten now correctly flattens message/rfc822
messages parsed by email.Parser.HeaderParser. messages parsed by email.Parser.HeaderParser.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment