Commit b97a6b9f authored by Guido van Rossum's avatar Guido van Rossum

fixed bugs in generic_setattr (returned NULL instead of

  -1 for errors)
parent fc145b12
...@@ -325,7 +325,7 @@ generic_setattr(g, name, v) ...@@ -325,7 +325,7 @@ generic_setattr(g, name, v)
if (v == NULL) { if (v == NULL) {
err_setstr(TypeError, "can't delete forms object attributes"); err_setstr(TypeError, "can't delete forms object attributes");
return NULL; return -1;
} }
/* "label" is an exception: setmember doesn't set strings; /* "label" is an exception: setmember doesn't set strings;
...@@ -333,7 +333,7 @@ generic_setattr(g, name, v) ...@@ -333,7 +333,7 @@ generic_setattr(g, name, v)
if (strcmp(name, "label") == 0) { if (strcmp(name, "label") == 0) {
if (!is_stringobject(v)) { if (!is_stringobject(v)) {
err_setstr(TypeError, "label attr must be string"); err_setstr(TypeError, "label attr must be string");
return NULL; return -1;
} }
fl_set_object_label(g->ob_generic, getstringvalue(v)); fl_set_object_label(g->ob_generic, getstringvalue(v));
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment