Commit bc2c4c99 authored by Antoine Pitrou's avatar Antoine Pitrou

Replace bad ftp URLs in test_urllib2net

parent 637e4544
...@@ -103,9 +103,9 @@ class OtherNetworkTests(unittest.TestCase): ...@@ -103,9 +103,9 @@ class OtherNetworkTests(unittest.TestCase):
def test_ftp(self): def test_ftp(self):
urls = [ urls = [
'ftp://ftp.kernel.org/pub/linux/kernel/README', 'ftp://ftp.debian.org/debian/README',
'ftp://ftp.kernel.org/pub/linux/kernel/non-existent-file', ('ftp://ftp.debian.org/debian/non-existent-file',
#'ftp://ftp.kernel.org/pub/leenox/kernel/test', None, urllib.error.URLError),
'ftp://gatekeeper.research.compaq.com/pub/DEC/SRC' 'ftp://gatekeeper.research.compaq.com/pub/DEC/SRC'
'/research-reports/00README-Legal-Rules-Regs', '/research-reports/00README-Legal-Rules-Regs',
] ]
...@@ -215,21 +215,22 @@ class OtherNetworkTests(unittest.TestCase): ...@@ -215,21 +215,22 @@ class OtherNetworkTests(unittest.TestCase):
urlopen = _wrap_with_retry_thrice(urlopen, urllib.error.URLError) urlopen = _wrap_with_retry_thrice(urlopen, urllib.error.URLError)
for url in urls: for url in urls:
with self.subTest(url=url):
if isinstance(url, tuple): if isinstance(url, tuple):
url, req, expected_err = url url, req, expected_err = url
else: else:
req = expected_err = None req = expected_err = None
with support.transient_internet(url): with support.transient_internet(url):
debug(url)
try: try:
f = urlopen(url, req, TIMEOUT) f = urlopen(url, req, TIMEOUT)
except OSError as err: except OSError as err:
debug(err)
if expected_err: if expected_err:
msg = ("Didn't get expected error(s) %s for %s %s, got %s: %s" % msg = ("Didn't get expected error(s) %s for %s %s, got %s: %s" %
(expected_err, url, req, type(err), err)) (expected_err, url, req, type(err), err))
self.assertIsInstance(err, expected_err, msg) self.assertIsInstance(err, expected_err, msg)
else:
raise
except urllib.error.URLError as err: except urllib.error.URLError as err:
if isinstance(err[0], socket.timeout): if isinstance(err[0], socket.timeout):
print("<timeout: %s>" % url, file=sys.stderr) print("<timeout: %s>" % url, file=sys.stderr)
...@@ -246,7 +247,6 @@ class OtherNetworkTests(unittest.TestCase): ...@@ -246,7 +247,6 @@ class OtherNetworkTests(unittest.TestCase):
except socket.timeout: except socket.timeout:
print("<timeout: %s>" % url, file=sys.stderr) print("<timeout: %s>" % url, file=sys.stderr)
f.close() f.close()
debug("******** next url coming up...")
time.sleep(0.1) time.sleep(0.1)
def _extra_handlers(self): def _extra_handlers(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment