Commit bdeacba5 authored by R. David Murray's avatar R. David Murray

Improve test_support.import_module docstring, remove

deprecated flag from get_attribute since it isn't likely
to do anything useful.
parent df90b024
...@@ -43,8 +43,11 @@ class ResourceDenied(unittest.SkipTest): ...@@ -43,8 +43,11 @@ class ResourceDenied(unittest.SkipTest):
""" """
def import_module(name, deprecated=False): def import_module(name, deprecated=False):
"""Import the module to be tested, raising SkipTest if it is not """Import and return the module to be tested, raising SkipTest if
available.""" it is not available.
If deprecated is True, any module or package deprecation messages
will be suppressed."""
with warnings.catch_warnings(): with warnings.catch_warnings():
if deprecated: if deprecated:
warnings.filterwarnings("ignore", ".+ (module|package)", warnings.filterwarnings("ignore", ".+ (module|package)",
...@@ -56,18 +59,13 @@ def import_module(name, deprecated=False): ...@@ -56,18 +59,13 @@ def import_module(name, deprecated=False):
else: else:
return module return module
def get_attribute(module, name, deprecated=False): def get_attribute(obj, name):
"""Get an attribute from the module, raising SkipTest if it is """Get an attribute, raising SkipTest if AttributeError is raised."""
not available."""
with warnings.catch_warnings():
if deprecated:
warnings.filterwarnings("ignore", ".+ (module|package)",
DeprecationWarning)
try: try:
attribute = getattr(module, name) attribute = getattr(obj, name)
except AttributeError: except AttributeError:
raise unittest.SkipTest("module %s has no attribute %s" % ( raise unittest.SkipTest("module %s has no attribute %s" % (
module.__name__, name)) obj.__name__, name))
else: else:
return attribute return attribute
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment