Commit c45fc767 authored by Victor Stinner's avatar Victor Stinner Committed by GitHub

bpo-33718: regrtest: use "xxx then yyy" result if re-run (GH-7521)

If tests are re-run, use "xxx then yyy" result format (ex: "FAILURE
then SUCCESS") to show that some failing tests have been re-run.

Add also test_regrtest.test_rerun_fail() test.
parent 396ecb9c
...@@ -79,6 +79,7 @@ class Regrtest: ...@@ -79,6 +79,7 @@ class Regrtest:
self.resource_denieds = [] self.resource_denieds = []
self.environment_changed = [] self.environment_changed = []
self.rerun = [] self.rerun = []
self.first_result = None
self.interrupted = False self.interrupted = False
# used by --slow # used by --slow
...@@ -273,6 +274,8 @@ class Regrtest: ...@@ -273,6 +274,8 @@ class Regrtest:
self.ns.failfast = False self.ns.failfast = False
self.ns.verbose3 = False self.ns.verbose3 = False
self.first_result = self.get_tests_result()
print() print()
print("Re-running failed tests in verbose mode") print("Re-running failed tests in verbose mode")
self.rerun = self.bad[:] self.rerun = self.bad[:]
...@@ -447,7 +450,10 @@ class Regrtest: ...@@ -447,7 +450,10 @@ class Regrtest:
if not result: if not result:
result.append("SUCCESS") result.append("SUCCESS")
return ', '.join(result) result = ', '.join(result)
if self.first_result:
result = '%s then %s' % (self.first_result, result)
return result
def run_tests(self): def run_tests(self):
# For a partial run, we do not need to clutter the output. # For a partial run, we do not need to clutter the output.
......
...@@ -390,6 +390,7 @@ class BaseTestCase(unittest.TestCase): ...@@ -390,6 +390,7 @@ class BaseTestCase(unittest.TestCase):
def check_executed_tests(self, output, tests, skipped=(), failed=(), def check_executed_tests(self, output, tests, skipped=(), failed=(),
env_changed=(), omitted=(), env_changed=(), omitted=(),
rerun=(),
randomize=False, interrupted=False, randomize=False, interrupted=False,
fail_env_changed=False): fail_env_changed=False):
if isinstance(tests, str): if isinstance(tests, str):
...@@ -402,6 +403,8 @@ class BaseTestCase(unittest.TestCase): ...@@ -402,6 +403,8 @@ class BaseTestCase(unittest.TestCase):
env_changed = [env_changed] env_changed = [env_changed]
if isinstance(omitted, str): if isinstance(omitted, str):
omitted = [omitted] omitted = [omitted]
if isinstance(rerun, str):
rerun = [rerun]
executed = self.parse_executed_tests(output) executed = self.parse_executed_tests(output)
if randomize: if randomize:
...@@ -436,6 +439,14 @@ class BaseTestCase(unittest.TestCase): ...@@ -436,6 +439,14 @@ class BaseTestCase(unittest.TestCase):
regex = list_regex('%s test%s omitted', omitted) regex = list_regex('%s test%s omitted', omitted)
self.check_line(output, regex) self.check_line(output, regex)
if rerun:
regex = list_regex('%s re-run test%s', rerun)
self.check_line(output, regex)
self.check_line(output, "Re-running failed tests in verbose mode")
for name in rerun:
regex = "Re-running test %r in verbose mode" % name
self.check_line(output, regex)
good = (len(tests) - len(skipped) - len(failed) good = (len(tests) - len(skipped) - len(failed)
- len(omitted) - len(env_changed)) - len(omitted) - len(env_changed))
if good: if good:
...@@ -447,14 +458,19 @@ class BaseTestCase(unittest.TestCase): ...@@ -447,14 +458,19 @@ class BaseTestCase(unittest.TestCase):
if interrupted: if interrupted:
self.check_line(output, 'Test suite interrupted by signal SIGINT.') self.check_line(output, 'Test suite interrupted by signal SIGINT.')
result = []
if failed: if failed:
result = 'FAILURE' result.append('FAILURE')
elif interrupted:
result = 'INTERRUPTED'
elif fail_env_changed and env_changed: elif fail_env_changed and env_changed:
result = 'ENV CHANGED' result.append('ENV CHANGED')
else: if interrupted:
result = 'SUCCESS' result.append('INTERRUPTED')
if not result:
result.append('SUCCESS')
result = ', '.join(result)
if rerun:
self.check_line(output, 'Tests result: %s' % result)
result = 'FAILURE then %s' % result
self.check_line(output, 'Tests result: %s' % result) self.check_line(output, 'Tests result: %s' % result)
def parse_random_seed(self, output): def parse_random_seed(self, output):
...@@ -948,6 +964,21 @@ class ArgsTestCase(BaseTestCase): ...@@ -948,6 +964,21 @@ class ArgsTestCase(BaseTestCase):
self.check_executed_tests(output, [testname], env_changed=testname, self.check_executed_tests(output, [testname], env_changed=testname,
fail_env_changed=True) fail_env_changed=True)
def test_rerun_fail(self):
code = textwrap.dedent("""
import unittest
class Tests(unittest.TestCase):
def test_bug(self):
# test always fail
self.fail("bug")
""")
testname = self.create_test(code=code)
output = self.run_tests("-w", testname, exitcode=2)
self.check_executed_tests(output, [testname],
failed=testname, rerun=testname)
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment