Issue #18408: Fix iobase_readline(), handle PyByteArray_Resize() failure

cc024d18 · Victor Stinner · af8b7e82 · cc024d18
Commit cc024d18 authored Oct 29, 2013 by Victor Stinner
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 5 deletions

Modules/_io/iobase.c Modules/_io/iobase.c +8 -5

No files found.
--- a/Modules/_io/iobase.c
+++ b/Modules/_io/iobase.c
@@ -530,7 +530,10 @@ iobase_readline(PyObject *self, PyObject *args)
        }

        old_size = PyByteArray_GET_SIZE(buffer);
-        PyByteArray_Resize(buffer, old_size + PyBytes_GET_SIZE(b));
+        if (PyByteArray_Resize(buffer, old_size + PyBytes_GET_SIZE(b)) < 0) {
+            Py_DECREF(b);
+            goto fail;
+        }
        memcpy(PyByteArray_AS_STRING(buffer) + old_size,
               PyBytes_AS_STRING(b), PyBytes_GET_SIZE(b));