Commit cc0bbbc7 authored by Victor Stinner's avatar Victor Stinner

(Merge 3.4) Issue #9246: On POSIX, os.getcwd() now supports paths longer than

1025 bytes. Patch written by William Orr.
parents 51f58059 4403d7de
...@@ -15,6 +15,9 @@ Core and Builtins ...@@ -15,6 +15,9 @@ Core and Builtins
Library Library
------- -------
- Issue #9246: On POSIX, os.getcwd() now supports paths longer than 1025 bytes.
Patch written by William Orr.
- Issue #17445: add difflib.diff_bytes() to support comparison of - Issue #17445: add difflib.diff_bytes() to support comparison of
byte strings (fixes a regression from Python 2). byte strings (fixes a regression from Python 2).
......
...@@ -3267,12 +3267,15 @@ os_lchown_impl(PyModuleDef *module, path_t *path, uid_t uid, gid_t gid) ...@@ -3267,12 +3267,15 @@ os_lchown_impl(PyModuleDef *module, path_t *path, uid_t uid, gid_t gid)
static PyObject * static PyObject *
posix_getcwd(int use_bytes) posix_getcwd(int use_bytes)
{ {
char buf[1026]; char *buf, *tmpbuf;
char *res; char *cwd;
const size_t chunk = 1024;
size_t buflen = 0;
PyObject *obj;
#ifdef MS_WINDOWS #ifdef MS_WINDOWS
if (!use_bytes) { if (!use_bytes) {
wchar_t wbuf[1026]; wchar_t wbuf[MAXPATHLEN];
wchar_t *wbuf2 = wbuf; wchar_t *wbuf2 = wbuf;
PyObject *resobj; PyObject *resobj;
DWORD len; DWORD len;
...@@ -3306,14 +3309,31 @@ posix_getcwd(int use_bytes) ...@@ -3306,14 +3309,31 @@ posix_getcwd(int use_bytes)
return NULL; return NULL;
#endif #endif
buf = cwd = NULL;
Py_BEGIN_ALLOW_THREADS Py_BEGIN_ALLOW_THREADS
res = getcwd(buf, sizeof buf); do {
buflen += chunk;
tmpbuf = PyMem_RawRealloc(buf, buflen);
if (tmpbuf == NULL)
break;
buf = tmpbuf;
cwd = getcwd(buf, buflen);
} while (cwd == NULL && errno == ERANGE);
Py_END_ALLOW_THREADS Py_END_ALLOW_THREADS
if (res == NULL)
if (cwd == NULL) {
PyMem_RawFree(buf);
return posix_error(); return posix_error();
}
if (use_bytes) if (use_bytes)
return PyBytes_FromStringAndSize(buf, strlen(buf)); obj = PyBytes_FromStringAndSize(buf, strlen(buf));
return PyUnicode_DecodeFSDefault(buf); else
obj = PyUnicode_DecodeFSDefault(buf);
PyMem_RawFree(buf);
return obj;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment