Issue #24377: Fix a ref leak in OrderedDict.__repr__.

Issue #24377: Fix a ref leak in OrderedDict.repr.
db4061cb · Eric Snow · 4c72918a · db4061cb · db4061cb
Commit db4061cb authored Jun 03, 2015 by Eric Snow
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

Misc/NEWS Misc/NEWS +2 -0

Objects/odictobject.c Objects/odictobject.c +1 -1

No files found.
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -25,6 +25,8 @@ Library
 - Issue #24362: Simplify the C OrderedDict fast nodes resize logic.
+- Issue #24377: Fix a ref leak in OrderedDict.__repr__.
 What's New in Python 3.5.0 beta 2?
 ==================================

--- a/Objects/odictobject.c
+++ b/Objects/odictobject.c
@@ -1578,7 +1578,7 @@ odict_repr(PyODictObject *self)
            if (value == NULL) {
                if (!PyErr_Occurred())
                    PyErr_SetObject(PyExc_KeyError, key);
-                return NULL;
+                goto Done;
            }
            pair = PyTuple_Pack(2, key, value);
            if (pair == NULL)