Fix the return value of set_discard (issue #10519)

e0aa8037 · Petri Lehtinen · 5acc27eb · e0aa8037
Commit e0aa8037 authored Oct 30, 2011 by Petri Lehtinen
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

Objects/setobject.c Objects/setobject.c +3 -2

No files found.
--- a/Objects/setobject.c
+++ b/Objects/setobject.c
@@ -1942,9 +1942,10 @@ set_discard(PySetObject *so, PyObject *key)
        tmpkey = make_new_set(&PyFrozenSet_Type, key);
        if (tmpkey == NULL)
            return NULL;
-        result = set_discard_key(so, tmpkey);
+        rv = set_discard_key(so, tmpkey);
        Py_DECREF(tmpkey);
-        return result;
+        if (rv == -1)
+            return NULL;
    }
    Py_RETURN_NONE;
 }