Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
e41682b9
Commit
e41682b9
authored
Jun 06, 2012
by
Richard Oudkerk
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #12157: pool.map() does not handle empty iterable correctly
Initial patch by mouad
parent
a3a164a0
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
19 additions
and
3 deletions
+19
-3
Lib/multiprocessing/pool.py
Lib/multiprocessing/pool.py
+1
-0
Lib/test/test_multiprocessing.py
Lib/test/test_multiprocessing.py
+15
-3
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/multiprocessing/pool.py
View file @
e41682b9
...
...
@@ -584,6 +584,7 @@ class MapResult(ApplyResult):
if
chunksize
<=
0
:
self
.
_number_left
=
0
self
.
_ready
=
True
del
cache
[
self
.
_job
]
else
:
self
.
_number_left
=
length
//
chunksize
+
bool
(
length
%
chunksize
)
...
...
Lib/test/test_multiprocessing.py
View file @
e41682b9
...
...
@@ -1178,6 +1178,18 @@ class _TestPool(BaseTestCase):
join
()
self
.
assertLess
(
join
.
elapsed
,
0.5
)
def
test_empty_iterable
(
self
):
# See Issue 12157
p
=
self
.
Pool
(
1
)
self
.
assertEqual
(
p
.
map
(
sqr
,
[]),
[])
self
.
assertEqual
(
list
(
p
.
imap
(
sqr
,
[])),
[])
self
.
assertEqual
(
list
(
p
.
imap_unordered
(
sqr
,
[])),
[])
self
.
assertEqual
(
p
.
map_async
(
sqr
,
[]).
get
(),
[])
p
.
close
()
p
.
join
()
def
raising
():
raise
KeyError
(
"key"
)
...
...
@@ -2176,7 +2188,7 @@ class ProcessesMixin(object):
'Queue'
,
'Lock'
,
'RLock'
,
'Semaphore'
,
'BoundedSemaphore'
,
'Condition'
,
'Event'
,
'Value'
,
'Array'
,
'RawValue'
,
'RawArray'
,
'current_process'
,
'active_children'
,
'Pipe'
,
'connection'
,
'JoinableQueue'
'connection'
,
'JoinableQueue'
,
'Pool'
)))
testcases_processes
=
create_test_cases
(
ProcessesMixin
,
type
=
'processes'
)
...
...
@@ -2190,7 +2202,7 @@ class ManagerMixin(object):
locals
().
update
(
get_attributes
(
manager
,
(
'Queue'
,
'Lock'
,
'RLock'
,
'Semaphore'
,
'BoundedSemaphore'
,
'Condition'
,
'Event'
,
'Value'
,
'Array'
,
'list'
,
'dict'
,
'Namespace'
,
'JoinableQueue'
'Namespace'
,
'JoinableQueue'
,
'Pool'
)))
testcases_manager
=
create_test_cases
(
ManagerMixin
,
type
=
'manager'
)
...
...
@@ -2204,7 +2216,7 @@ class ThreadsMixin(object):
'Queue'
,
'Lock'
,
'RLock'
,
'Semaphore'
,
'BoundedSemaphore'
,
'Condition'
,
'Event'
,
'Value'
,
'Array'
,
'current_process'
,
'active_children'
,
'Pipe'
,
'connection'
,
'dict'
,
'list'
,
'Namespace'
,
'JoinableQueue'
'Namespace'
,
'JoinableQueue'
,
'Pool'
)))
testcases_threads
=
create_test_cases
(
ThreadsMixin
,
type
=
'threads'
)
...
...
Misc/NEWS
View file @
e41682b9
...
...
@@ -70,6 +70,9 @@ Core and Builtins
Library
-------
- Issue #12157: Make pool.map() empty iterables correctly. Initial
patch by mouad.
- Issue #14992: os.makedirs(path, exist_ok=True) would raise an OSError
when the path existed and had the S_ISGID mode bit set when it was
not explicitly asked for. This is no longer an exception as mkdir
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment