Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
e92dc9c2
Commit
e92dc9c2
authored
Jun 25, 2016
by
Brett Cannon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix a scoping issue where an UnboundLocalError was triggered if a
lazy-loaded module was already in sys.modules.
parent
559ad5d4
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
18 additions
and
4 deletions
+18
-4
Lib/importlib/util.py
Lib/importlib/util.py
+1
-1
Lib/test/test_importlib/test_lazy.py
Lib/test/test_importlib/test_lazy.py
+13
-3
Misc/NEWS
Misc/NEWS
+4
-0
No files found.
Lib/importlib/util.py
View file @
e92dc9c2
Lib/test/test_importlib/test_lazy.py
View file @
e92dc9c2
import
importlib
from
importlib
import
abc
from
importlib
import
util
import
sys
import
types
import
unittest
from
.
import
util
as
test_util
...
...
@@ -122,10 +124,18 @@ class LazyLoaderTests(unittest.TestCase):
self
.
assertFalse
(
hasattr
(
module
,
'__name__'
))
def
test_module_substitution_error
(
self
):
source_code
=
'import sys; sys.modules[__name__] = 42'
module
=
self
.
new_module
(
source_code
)
with
test_util
.
uncache
(
TestingImporter
.
module_name
):
with
self
.
assertRaises
(
ValueError
):
fresh_module
=
types
.
ModuleType
(
TestingImporter
.
module_name
)
sys
.
modules
[
TestingImporter
.
module_name
]
=
fresh_module
module
=
self
.
new_module
()
with
self
.
assertRaisesRegex
(
ValueError
,
"substituted"
):
module
.
__name__
def
test_module_already_in_sys
(
self
):
with
test_util
.
uncache
(
TestingImporter
.
module_name
):
module
=
self
.
new_module
()
sys
.
modules
[
TestingImporter
.
module_name
]
=
module
# Force the load; just care that no exception is raised.
module
.
__name__
...
...
Misc/NEWS
View file @
e92dc9c2
...
...
@@ -13,6 +13,10 @@ Core and Builtins
Library
-------
- Fix a scoping issue in importlib.util.LazyLoader which triggered an
UnboundLocalError when lazy-loading a module that was already put into
sys.modules.
- Issue #27079: Fixed curses.ascii functions isblank(), iscntrl() and ispunct().
- Issue #26754: Some functions (compile() etc) accepted a filename argument
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment