Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
ed10a30e
Commit
ed10a30e
authored
Nov 29, 2012
by
Benjamin Peterson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
enumerate only requires an iterable (closes #16573)
Patch by Jonathan Kotta.
parent
ac26a2e7
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
6 deletions
+18
-6
Lib/lib2to3/fixer_util.py
Lib/lib2to3/fixer_util.py
+6
-6
Lib/lib2to3/tests/test_fixers.py
Lib/lib2to3/tests/test_fixers.py
+12
-0
No files found.
Lib/lib2to3/fixer_util.py
View file @
ed10a30e
...
...
@@ -165,7 +165,7 @@ def parenthesize(node):
consuming_calls
=
set
([
"sorted"
,
"list"
,
"set"
,
"any"
,
"all"
,
"tuple"
,
"sum"
,
"min"
,
"max"
])
"min"
,
"max"
,
"enumerate"
])
def
attr_chain
(
obj
,
attr
):
"""Follow an attribute chain.
...
...
@@ -192,14 +192,14 @@ p0 = """for_stmt< 'for' any 'in' node=any ':' any* >
p1
=
"""
power<
( 'iter' | 'list' | 'tuple' | 'sorted' | 'set' | 'sum' |
'any' | 'all' | (any* trailer< '.' 'join' >) )
'any' | 'all' |
'enumerate' |
(any* trailer< '.' 'join' >) )
trailer< '(' node=any ')' >
any*
>
"""
p2
=
"""
power<
'sorted'
( 'sorted' | 'enumerate' )
trailer< '(' arglist<node=any any*> ')' >
any*
>
...
...
@@ -207,14 +207,14 @@ power<
pats_built
=
False
def
in_special_context
(
node
):
""" Returns true if node is in an environment where all that is required
of it is being it
t
erable (ie, it doesn't matter if it returns a list
or an it
t
erator).
of it is being iterable (ie, it doesn't matter if it returns a list
or an iterator).
See test_map_nochange in test_fixers.py for some examples and tests.
"""
global
p0
,
p1
,
p2
,
pats_built
if
not
pats_built
:
p1
=
patcomp
.
compile_pattern
(
p1
)
p0
=
patcomp
.
compile_pattern
(
p0
)
p1
=
patcomp
.
compile_pattern
(
p1
)
p2
=
patcomp
.
compile_pattern
(
p2
)
pats_built
=
True
patterns
=
[
p0
,
p1
,
p2
]
...
...
Lib/lib2to3/tests/test_fixers.py
View file @
ed10a30e
...
...
@@ -2981,6 +2981,10 @@ class Test_filter(FixerTestCase):
self
.
unchanged
(
a
)
a
=
"""sorted(filter(f, 'abc'), key=blah)[0]"""
self
.
unchanged
(
a
)
a
=
"""enumerate(filter(f, 'abc'))"""
self
.
unchanged
(
a
)
a
=
"""enumerate(filter(f, 'abc'), start=1)"""
self
.
unchanged
(
a
)
a
=
"""for i in filter(f, 'abc'): pass"""
self
.
unchanged
(
a
)
a
=
"""[x for x in filter(f, 'abc')]"""
...
...
@@ -3089,6 +3093,10 @@ class Test_map(FixerTestCase):
self
.
unchanged
(
a
)
a
=
"""sorted(map(f, 'abc'), key=blah)[0]"""
self
.
unchanged
(
a
)
a
=
"""enumerate(map(f, 'abc'))"""
self
.
unchanged
(
a
)
a
=
"""enumerate(map(f, 'abc'), start=1)"""
self
.
unchanged
(
a
)
a
=
"""for i in map(f, 'abc'): pass"""
self
.
unchanged
(
a
)
a
=
"""[x for x in map(f, 'abc')]"""
...
...
@@ -3152,6 +3160,10 @@ class Test_zip(FixerTestCase):
self
.
unchanged
(
a
)
a
=
"""sorted(zip(a, b), key=blah)[0]"""
self
.
unchanged
(
a
)
a
=
"""enumerate(zip(a, b))"""
self
.
unchanged
(
a
)
a
=
"""enumerate(zip(a, b), start=1)"""
self
.
unchanged
(
a
)
a
=
"""for i in zip(a, b): pass"""
self
.
unchanged
(
a
)
a
=
"""[x for x in zip(a, b)]"""
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment