#1479: Fix refleak in csv module (from rev 59062).

f5192615 · Georg Brandl · ceab6104 · f5192615
Commit f5192615 authored Nov 25, 2007 by Georg Brandl
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 6 deletions

Modules/_csv.c Modules/_csv.c +5 -6

No files found.
--- a/Modules/_csv.c
+++ b/Modules/_csv.c
@@ -793,14 +793,13 @@ Reader_iternext(ReaderObj *self)
 					     "newline inside string");
                        return NULL;
                }
-		if (!PyUnicode_Check(lineobj))
+		if (!PyUnicode_Check(lineobj)) {
-		{
+			PyErr_Format(error_obj, "iterator should return "
-			PyErr_Format(error_obj,
+				     "strings, not %.200s (did you open "
-				     "Iterator should return strings, "
+				     "the file in text mode?)",
-				     "not %.200s "
-				     "(did you open the file in text mode?)",
 				     lineobj->ob_type->tp_name
 				);
+			Py_DECREF(lineobj);
 			return NULL;
 		}
                ++self->line_num;